This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4015

revlog: don't include trailing nullrev in revlog.revs(stop=len(revlog))
ClosedPublic

Authored by martinvonz on Aug 1 2018, 2:47 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG83a505b5cf85: revlog: don't include trailing nullrev in revlog.revs(stop=len(revlog))
Summary

This was an odd side effect of the nullid entry that's in the
index. The existing callers (mostly repair.py) seem to have handled it
fine. It doesn't seem intentional, and it's pretty surprising, so
let's remove that surprise.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (5 lines)

Diff 9715

mercurial/revlog.py

return 0 <= rev < len(self) return 0 <= rev < len(self)
def __len__(self): def __len__(self):
return len(self.index) - 1 return len(self.index) - 1
def __iter__(self): def __iter__(self):
return iter(xrange(len(self))) return iter(xrange(len(self)))
def revs(self, start=0, stop=None): def revs(self, start=0, stop=None):
"""iterate over all rev in this revlog (from start to stop)""" """iterate over all rev in this revlog (from start to stop)"""
step = 1 step = 1
length = len(self)
if stop is not None: if stop is not None:
if start > stop: if start > stop:
step = -1 step = -1
stop += step stop += step
if stop > length:
stop = length
else: else:
stop = len(self) stop = length
return xrange(start, stop, step) return xrange(start, stop, step)
@util.propertycache @util.propertycache
def nodemap(self): def nodemap(self):
self.rev(self.node(0)) self.rev(self.node(0))
return self._nodecache return self._nodecache
def hasnode(self, node): def hasnode(self, node):