This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: move revision maps to cgpacker
ClosedPublic

Authored by indygreg on Aug 3 2018, 5:04 PM.

Details

Summary

And remove the underscores so the variables conform to our
naming convention.

The logic in _close() should be the only thing warranting scrutiny
during review.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 3 2018, 5:04 PM
This revision was automatically updated to reflect the committed changes.
indygreg added inline comments.
mercurial/changegroup.py
602–603

There are 2 bugs here.

One is dropping the _ prefix from clrevtolocalrev.

The other is aliasing the variables then calling .clear(), which has the effect of undoing both and effectively nerfing self._nextclrevtolocalrev.

Surprisingly no tests failed as a result of these bugs. So I'm not sure what's going on.

Maybe @spectral, @martinvonz, or @durin42 know what's up.