This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4180

tests: rename variables in revlog index parse test for clarity
ClosedPublic

Authored by durin42 on Aug 9 2018, 1:42 PM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHGee0720e82257: tests: rename variables in revlog index parse test for clarity

Summary

Now it's unambiguous which one is the expected value. c_res_{1,2} was
also misleading a bit because in --pure mode we're testing the old
slow Python version against the modern optimized Python version.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

durin42 created this revision.Aug 9 2018, 1:42 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 9 2018, 1:42 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

durin42 added a child revision: D4181: tests: port remaining bits of test-parseindex2 to unittest asserts.Aug 9 2018, 1:42 PM

durin42 updated this revision to Diff 10123.Aug 9 2018, 1:45 PM

pulkit accepted this revision.Aug 9 2018, 3:04 PM

Closed by commit rHGee0720e82257: tests: rename variables in revlog index parse test for clarity (authored by durin42). · Explain WhyAug 9 2018, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-parseindex2.py (12 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10112		Aug 9 2018, 1:42 PM	★	★
Diff 2	10123		Aug 9 2018, 1:45 PM	★	★
Diff 3	10171	rHGee0720e8225726471fbaadf2e7f94ed1286f913d	Aug 9 2018, 1:08 PM	★	★

Commit	Parents	Author	Summary	Date
		Augie Fackler		Aug 9 2018, 1:08 PM

Status	Author	Revision
Closed	durin42	D4185 tests: remove expected output of test-parseindex2.py
Closed	durin42	D4184 tests: add test coverage for revlogindex[-1] which was previously missing
Closed	durin42	D4183 parsers: adjust pure-python version to mimic a3dacabd476b
Closed	durin42	D4182 tests: restore Python 3 compat in test-parseindex2.py
Closed	durin42	D4181 tests: port remaining bits of test-parseindex2 to unittest asserts
Closed	durin42	D4180 tests: rename variables in revlog index parse test for clarity
Closed	durin42	D4179 tests: move assertion closer to want/got declarations in test-parseindex2.py
Closed	durin42	D4178 tests: move chunks of test-parseindex2.py to use unittest properly
Closed	durin42	D4177 tests: fix up indent width in test-parseindex2.py
Closed	durin42	D4176 tests: start moving test-parseindex2.py to a unittest

Diff 10123

tests/test-parseindex2.py

	with self.assertRaises(TypeError):			with self.assertRaises(TypeError):
	parse_index2(0, True)			parse_index2(0, True)

	def testparseindexfile(self):			def testparseindexfile(self):
	# Check parsers.parse_index2() on an index file against the			# Check parsers.parse_index2() on an index file against the
	# original Python implementation of parseindex, both with and			# original Python implementation of parseindex, both with and
	# without inlined data.			# without inlined data.

	py_res_1 = py_parseindex(data_inlined, True)			want = py_parseindex(data_inlined, True)
	c_res_1 = parse_index2(data_inlined, True)			got = parse_index2(data_inlined, True)
	self.assertEqual(py_res_1, c_res_1) # inline data			self.assertEqual(want, got) # inline data

	py_res_2 = py_parseindex(data_non_inlined, False)			want = py_parseindex(data_non_inlined, False)
	c_res_2 = parse_index2(data_non_inlined, False)			got = parse_index2(data_non_inlined, False)
	self.assertEqual(py_res_2, c_res_2) # no inline data			self.assertEqual(want, got) # no inline data

	ix = parsers.parse_index2(data_inlined, True)[0]			ix = parsers.parse_index2(data_inlined, True)[0]
	for i, r in enumerate(ix):			for i, r in enumerate(ix):
	if r[7] == nullid:			if r[7] == nullid:
	i = -1			i = -1
	try:			try:
	self.assertEqual(			self.assertEqual(
	ix[r[7]], i,			ix[r[7]], i,