( )⚙ D4180 tests: rename variables in revlog index parse test for clarity

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4180

tests: rename variables in revlog index parse test for clarity
ClosedPublic

Authored by durin42 on Aug 9 2018, 1:42 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGee0720e82257: tests: rename variables in revlog index parse test for clarity
Summary

Now it's unambiguous which one is the expected value. c_res_{1,2} was
also misleading a bit because in --pure mode we're testing the old
slow Python version against the modern optimized Python version.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 9 2018, 1:42 PM
durin42 updated this revision to Diff 10123.Aug 9 2018, 1:45 PM
pulkit accepted this revision.Aug 9 2018, 3:04 PM
Closed by commit rHGee0720e82257: tests: rename variables in revlog index parse test for clarity (authored by durin42). · Explain WhyAug 9 2018, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex2.py (12 lines)

Diff 10171

tests/test-parseindex2.py

with self.assertRaises(TypeError): with self.assertRaises(TypeError):
parse_index2(0, True) parse_index2(0, True)
def testparseindexfile(self): def testparseindexfile(self):
# Check parsers.parse_index2() on an index file against the # Check parsers.parse_index2() on an index file against the
# original Python implementation of parseindex, both with and # original Python implementation of parseindex, both with and
# without inlined data. # without inlined data.
py_res_1 = py_parseindex(data_inlined, True) want = py_parseindex(data_inlined, True)
c_res_1 = parse_index2(data_inlined, True) got = parse_index2(data_inlined, True)
self.assertEqual(py_res_1, c_res_1) # inline data self.assertEqual(want, got) # inline data
py_res_2 = py_parseindex(data_non_inlined, False) want = py_parseindex(data_non_inlined, False)
c_res_2 = parse_index2(data_non_inlined, False) got = parse_index2(data_non_inlined, False)
self.assertEqual(py_res_2, c_res_2) # no inline data self.assertEqual(want, got) # no inline data
ix = parsers.parse_index2(data_inlined, True)[0] ix = parsers.parse_index2(data_inlined, True)[0]
for i, r in enumerate(ix): for i, r in enumerate(ix):
if r[7] == nullid: if r[7] == nullid:
i = -1 i = -1
try: try:
self.assertEqual( self.assertEqual(
ix[r[7]], i, ix[r[7]], i,