This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: extract cgpacker.group() to standalone function
ClosedPublic

Authored by indygreg on Aug 9 2018, 4:52 PM.

Details

Summary

It doesn't need to be part of the packer class.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 9 2018, 4:52 PM
durin42 added inline comments.
mercurial/changegroup.py
690

nit: bytes

(follow-up please, to avoid turnaround time issues)

indygreg marked an inline comment as done.Aug 9 2018, 10:18 PM
indygreg added inline comments.
mercurial/changegroup.py
690

I rewrite the docstring later in the series. I was trying to optimize for review by not changing anything as part of the code move :)

indygreg marked an inline comment as done.Aug 9 2018, 10:24 PM
This revision was automatically updated to reflect the committed changes.