This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4380

revert: fix the inconsistency of status msgs in --interactive mode
ClosedPublic

Authored by khanchi97 on Aug 26 2018, 7:06 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGcb70501d8b71: revert: fix the inconsistency of status msgs in --interactive mode
Summary

Before this patch we were priting every action msg before actually
performing that action and that was resulting in inconsistencies;
like in --interactive session if user decided to not revert any
changes in a file foo, still there will be a msg on console saying
"reverting foo".

To fix this, I have made some changes to print status msg just
before the action it is going to perform, no matter if --interactive
or not.

Changes made in test-revert-interactive.t reflect the changed behavior.
There are also some changes in test-revert.t because of change in the
order of messages.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Aug 26 2018, 7:06 PM
yuja added a subscriber: yuja.Aug 28 2018, 9:00 AM
$ hg revert a

+ undeleting a

As you can see, there was no status message if "a" is an explicitly specified
file.

@@ -3021,7 +3021,8 @@

if ui.verbose or not exact:
    if not isinstance(msg, bytes):
        msg = msg(abs)
  • ui.status(msg % rel)

+ if opts.get('dry_run'):
+ ui.status(msg % rel)

Before a relative path was printed, but new code would probably use the
repository-absolute path.

Perhaps we can pass in the matcher m to _performrevert() to translate
abs path to relative, and to test if status message should be printed.

+ repo.ui.status(_("%s") % (actions['forget'][1] % f))

Nit: _("%s") is noop. Just print actions['forget'][1] % f.

@@ -3141,14 +3147,21 @@

    tobackup = set()
# Apply changes
fp = stringio()

+ # fnames keep track of filenames for which we have initiated changes,
+ # to make sure that we print status msg only once for a file.
+ fnames = []

Nit: perhaps set() is better here since we have to test the existence
many times.

FWIW, no idea why revert() has to be such complicated.

khanchi97 edited the summary of this revision. (Show Details)Aug 30 2018, 4:55 PM
khanchi97 updated this revision to Diff 10679.
khanchi97 added a comment.Aug 30 2018, 5:12 PM

Made changes. Ready to review.

In D4380#67537, @yuja wrote:
$ hg revert a

+ undeleting a

As you can see, there was no status message if "a" is an explicitly specified
file.

Oh yes, added exact conditional.

@@ -3021,7 +3021,8 @@

if ui.verbose or not exact:
    if not isinstance(msg, bytes):
        msg = msg(abs)
  • ui.status(msg % rel)

+ if opts.get('dry_run'):
+ ui.status(msg % rel)

Before a relative path was printed, but new code would probably use the
repository-absolute path.
Perhaps we can pass in the matcher m to _performrevert() to translate
abs path to relative, and to test if status message should be printed.

I passed the names dict as it already have the required information.

+ repo.ui.status(_("%s") % (actions['forget'][1] % f))

Nit: _("%s") is noop. Just print actions['forget'][1] % f.

@@ -3141,14 +3147,21 @@

    tobackup = set()
# Apply changes
fp = stringio()

+ # fnames keep track of filenames for which we have initiated changes,
+ # to make sure that we print status msg only once for a file.
+ fnames = []

Nit: perhaps set() is better here since we have to test the existence
many times.
FWIW, no idea why revert() has to be such complicated.

mercurial/cmdutil.py
3024

Does this conditional doing something useful because I don't see any change in the tests if I remove line 3023,3024?

yuja added a comment.Aug 31 2018, 7:53 AM

+ if ui.verbose or not exact:
+ if not isinstance(msg, bytes):
+ msg = msg(abs)

Does this conditional doing something useful because I don't see any change in the tests if I remove line 3023,3024?

Probably no. msg should never be a callable since 0d57bf80c7cb.

yuja added a comment.Aug 31 2018, 7:53 AM

@@ -3034,7 +3035,19 @@

prefetch(repo, [ctx.rev()],
         matchfiles(repo,
                    [f for sublist in oplist for f in sublist]))
  • _performrevert(repo, parents, ctx, actions, interactive, tobackup)

+ # give status messages for actions to be performed
+ acts = "add drop undelete forget remove revert".split()
+ if interactive:
+ # exclude ("forget", "remove", "revert") as status msg for these
+ # actions will be handled in interactive session.
+ acts = acts[:3]
+ for act in acts:
+ for f in actions[act][0]:
+ rel, exact = names[f]
+ if ui.verbose or not exact:
+ ui.status(actions[act][1] % rel)
+ _performrevert(repo, parents, ctx, names, actions, interactive,
+ tobackup)

Looks generally good, but I think the original patch was better in that
status message is printed just before the action, no matter if interactive
or not.

+ rel, exact = names[f]
+ if repo.ui.verbose or not exact:
+ repo.ui.status(actions['forget'][1] % rel)

This can be factored out to a closure function if you think it's too verbose
to copy around.

khanchi97 edited the summary of this revision. (Show Details)Sep 3 2018, 1:53 AM
khanchi97 updated this revision to Diff 10715.
khanchi97 added a comment.Sep 3 2018, 2:23 AM

Ready to review.

yuja added a comment.Sep 3 2018, 7:32 AM

Queued, thanks.

Closed by commit rHGcb70501d8b71: revert: fix the inconsistency of status msgs in --interactive mode (authored by khanchi97). · Explain WhySep 3 2018, 8:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10722

mercurial/cmdutil.py

bakname = scmutil.origpath(ui, repo, rel) bakname = scmutil.origpath(ui, repo, rel)
ui.note(_('saving current version of %s as %s\n') % ui.note(_('saving current version of %s as %s\n') %
(rel, bakname)) (rel, bakname))
if not opts.get('dry_run'): if not opts.get('dry_run'):
if interactive: if interactive:
util.copyfile(target, bakname) util.copyfile(target, bakname)
else: else:
util.rename(target, bakname) util.rename(target, bakname)
if opts.get('dry_run'):
if ui.verbose or not exact: if ui.verbose or not exact:
ui.status(msg % rel) ui.status(msg % rel)
khanchi97AuthorUnsubmitted
Not Done

Does this conditional doing something useful because I don't see any change in the tests if I remove line 3023,3024?

khanchi97: Does this conditional doing something useful because I don't see any change in the tests if I…
elif exact: elif exact:
ui.warn(msg % rel) ui.warn(msg % rel)
break break
if not opts.get('dry_run'): if not opts.get('dry_run'):
needdata = ('revert', 'add', 'undelete') needdata = ('revert', 'add', 'undelete')
oplist = [actions[name][0] for name in needdata] oplist = [actions[name][0] for name in needdata]
prefetch = scmutil.prefetchfiles prefetch = scmutil.prefetchfiles
matchfiles = scmutil.matchfiles matchfiles = scmutil.matchfiles
prefetch(repo, [ctx.rev()], prefetch(repo, [ctx.rev()],
matchfiles(repo, matchfiles(repo,
[f for sublist in oplist for f in sublist])) [f for sublist in oplist for f in sublist]))
_performrevert(repo, parents, ctx, actions, interactive, tobackup) _performrevert(repo, parents, ctx, names, actions, interactive,
tobackup)
if targetsubs: if targetsubs:
# Revert the subrepos on the revert list # Revert the subrepos on the revert list
for sub in targetsubs: for sub in targetsubs:
try: try:
wctx.sub(sub).revert(ctx.substate[sub], *pats, wctx.sub(sub).revert(ctx.substate[sub], *pats,
**pycompat.strkwargs(opts)) **pycompat.strkwargs(opts))
except KeyError: except KeyError:
raise error.Abort("subrepository '%s' does not exist in %s!" raise error.Abort("subrepository '%s' does not exist in %s!"
% (sub, short(ctx.node()))) % (sub, short(ctx.node())))
def _performrevert(repo, parents, ctx, actions, interactive=False, def _performrevert(repo, parents, ctx, names, actions, interactive=False,
tobackup=None): tobackup=None):
"""function that actually perform all the actions computed for revert """function that actually perform all the actions computed for revert
This is an independent function to let extension to plug in and react to This is an independent function to let extension to plug in and react to
the imminent revert. the imminent revert.
Make sure you have the working directory locked when calling this function. Make sure you have the working directory locked when calling this function.
""" """
parent, p2 = parents parent, p2 = parents
node = ctx.node() node = ctx.node()
excluded_files = [] excluded_files = []
def checkout(f): def checkout(f):
fc = ctx[f] fc = ctx[f]
repo.wwrite(f, fc.data(), fc.flags()) repo.wwrite(f, fc.data(), fc.flags())
def doremove(f): def doremove(f):
try: try:
rmdir = repo.ui.configbool('experimental', 'removeemptydirs') rmdir = repo.ui.configbool('experimental', 'removeemptydirs')
repo.wvfs.unlinkpath(f, rmdir=rmdir) repo.wvfs.unlinkpath(f, rmdir=rmdir)
except OSError: except OSError:
pass pass
repo.dirstate.remove(f) repo.dirstate.remove(f)
def prntstatusmsg(action, f):
rel, exact = names[f]
if repo.ui.verbose or not exact:
repo.ui.status(actions[action][1] % rel)
audit_path = pathutil.pathauditor(repo.root, cached=True) audit_path = pathutil.pathauditor(repo.root, cached=True)
for f in actions['forget'][0]: for f in actions['forget'][0]:
if interactive: if interactive:
choice = repo.ui.promptchoice( choice = repo.ui.promptchoice(
_("forget added file %s (Yn)?$$ &Yes $$ &No") % f) _("forget added file %s (Yn)?$$ &Yes $$ &No") % f)
if choice == 0: if choice == 0:
prntstatusmsg('forget', f)
repo.dirstate.drop(f) repo.dirstate.drop(f)
else: else:
excluded_files.append(f) excluded_files.append(f)
else: else:
prntstatusmsg('forget', f)
repo.dirstate.drop(f) repo.dirstate.drop(f)
for f in actions['remove'][0]: for f in actions['remove'][0]:
audit_path(f) audit_path(f)
if interactive: if interactive:
choice = repo.ui.promptchoice( choice = repo.ui.promptchoice(
_("remove added file %s (Yn)?$$ &Yes $$ &No") % f) _("remove added file %s (Yn)?$$ &Yes $$ &No") % f)
if choice == 0: if choice == 0:
prntstatusmsg('remove', f)
doremove(f) doremove(f)
else: else:
excluded_files.append(f) excluded_files.append(f)
else: else:
prntstatusmsg('remove', f)
doremove(f) doremove(f)
for f in actions['drop'][0]: for f in actions['drop'][0]:
audit_path(f) audit_path(f)
prntstatusmsg('drop', f)
repo.dirstate.remove(f) repo.dirstate.remove(f)
normal = None normal = None
if node == parent: if node == parent:
# We're reverting to our parent. If possible, we'd like status # We're reverting to our parent. If possible, we'd like status
# to report the file as clean. We have to use normallookup for # to report the file as clean. We have to use normallookup for
# merges to avoid losing information about merged/dirty files. # merges to avoid losing information about merged/dirty files.
if p2 != nullid: if p2 != nullid:
except error.PatchError as err: except error.PatchError as err:
raise error.Abort(_('error parsing patch: %s') % err) raise error.Abort(_('error parsing patch: %s') % err)
newlyaddedandmodifiedfiles = newandmodified(chunks, originalchunks) newlyaddedandmodifiedfiles = newandmodified(chunks, originalchunks)
if tobackup is None: if tobackup is None:
tobackup = set() tobackup = set()
# Apply changes # Apply changes
fp = stringio() fp = stringio()
# `fnames` keeps track of filenames for which we have initiated changes,
# to make sure that we print status msg only once per file.
fnames = set()
for c in chunks: for c in chunks:
# Create a backup file only if this hunk should be backed up if ishunk(c):
if ishunk(c) and c.header.filename() in tobackup:
abs = c.header.filename() abs = c.header.filename()
if abs not in fnames:
fnames.add(abs)
prntstatusmsg('revert', abs)
# Create a backup file only if this hunk should be backed up
if c.header.filename() in tobackup:
target = repo.wjoin(abs) target = repo.wjoin(abs)
bakname = scmutil.origpath(repo.ui, repo, m.rel(abs)) bakname = scmutil.origpath(repo.ui, repo, m.rel(abs))
util.copyfile(target, bakname) util.copyfile(target, bakname)
tobackup.remove(abs) tobackup.remove(abs)
c.write(fp) c.write(fp)
dopatch = fp.tell() dopatch = fp.tell()
fp.seek(0) fp.seek(0)
if dopatch: if dopatch:
try: try:
patch.internalpatch(repo.ui, repo, fp, 1, eolmode=None) patch.internalpatch(repo.ui, repo, fp, 1, eolmode=None)
except error.PatchError as err: except error.PatchError as err:
raise error.Abort(pycompat.bytestr(err)) raise error.Abort(pycompat.bytestr(err))
del fp del fp
else: else:
for f in actions['revert'][0]: for f in actions['revert'][0]:
prntstatusmsg('revert', f)
checkout(f) checkout(f)
if normal: if normal:
normal(f) normal(f)
for f in actions['add'][0]: for f in actions['add'][0]:
# Don't checkout modified files, they are already created by the diff # Don't checkout modified files, they are already created by the diff
if f not in newlyaddedandmodifiedfiles: if f not in newlyaddedandmodifiedfiles:
prntstatusmsg('add', f)
checkout(f) checkout(f)
repo.dirstate.add(f) repo.dirstate.add(f)
normal = repo.dirstate.normallookup normal = repo.dirstate.normallookup
if node == parent and p2 == nullid: if node == parent and p2 == nullid:
normal = repo.dirstate.normal normal = repo.dirstate.normal
for f in actions['undelete'][0]: for f in actions['undelete'][0]:
prntstatusmsg('undelete', f)
checkout(f) checkout(f)
normal(f) normal(f)
copied = copies.pathcopies(repo[parent], ctx) copied = copies.pathcopies(repo[parent], ctx)
for f in actions['add'][0] + actions['undelete'][0] + actions['revert'][0]: for f in actions['add'][0] + actions['undelete'][0] + actions['revert'][0]:
if f in copied: if f in copied:
repo.dirstate.copy(copied[f], f) repo.dirstate.copy(copied[f], f)

tests/test-backout.t

$ hg remove b $ hg remove b
$ hg commit -d '5 0' -m 'prepare for subsequent backout' $ hg commit -d '5 0' -m 'prepare for subsequent backout'
$ touch -t 200001010000 c $ touch -t 200001010000 c
$ hg status -A $ hg status -A
C c C c
$ hg debugstate --nodates $ hg debugstate --nodates
n 644 12 set c n 644 12 set c
$ hg backout -d '6 0' -m 'to be rollback-ed soon' -r . $ hg backout -d '6 0' -m 'to be rollback-ed soon' -r .
adding b
removing c removing c
adding b
changeset 6:4bfec048029d backs out changeset 5:fac0b729a654 changeset 6:4bfec048029d backs out changeset 5:fac0b729a654
$ hg rollback -q $ hg rollback -q
$ hg status -A $ hg status -A
A b A b
R c R c
$ hg debugstate --nodates $ hg debugstate --nodates
a 0 -1 unset b a 0 -1 unset b
r 0 0 set c r 0 0 set c

tests/test-confused-revert.t

$ hg init $ hg init
$ echo foo > a $ echo foo > a
$ hg add a $ hg add a
$ hg commit -m "1" $ hg commit -m "1"
$ echo bar > b $ echo bar > b
$ hg add b $ hg add b
$ hg remove a $ hg remove a
Should show a removed and b added: Should show a removed and b added:
$ hg status $ hg status
A b A b
R a R a
$ hg revert --all $ hg revert --all
undeleting a
forgetting b forgetting b
undeleting a
Should show b unknown and a back to normal: Should show b unknown and a back to normal:
$ hg status $ hg status
? b ? b
$ rm b $ rm b
$ hg revert $ hg revert
abort: uncommitted merge with no revision specified abort: uncommitted merge with no revision specified
(use 'hg update' or see 'hg help revert') (use 'hg update' or see 'hg help revert')
[255] [255]
Revert should be ok now: Revert should be ok now:
$ hg revert -r2 --all $ hg revert -r2 --all
undeleting a
forgetting b forgetting b
undeleting a
Should show b unknown and a marked modified (merged): Should show b unknown and a marked modified (merged):
$ hg status $ hg status
M a M a
? b ? b
Should show foo-b: Should show foo-b:
$ cat a $ cat a
foo-b foo-b

tests/test-fileset-generated.t

undeleting content1_content2_content2-untracked undeleting content1_content2_content2-untracked
undeleting content1_content2_content3-untracked undeleting content1_content2_content3-untracked
undeleting content1_content2_missing-untracked undeleting content1_content2_missing-untracked
undeleting missing_content2_content2-untracked undeleting missing_content2_content2-untracked
undeleting missing_content2_content3-untracked undeleting missing_content2_content3-untracked
undeleting missing_content2_missing-untracked undeleting missing_content2_missing-untracked
$ hg revert 'set:deleted()' $ hg revert 'set:deleted()'
forgetting content1_missing_missing-tracked
forgetting missing_missing_missing-tracked
reverting content1_content1_missing-tracked reverting content1_content1_missing-tracked
reverting content1_content2_missing-tracked reverting content1_content2_missing-tracked
forgetting content1_missing_missing-tracked
reverting missing_content2_missing-tracked reverting missing_content2_missing-tracked
forgetting missing_missing_missing-tracked
$ hg revert 'set:unknown()' $ hg revert 'set:unknown()'
$ hg revert 'set:clean()' $ hg revert 'set:clean()'

tests/test-import-git.t

$ hg st --copies $ hg st --copies
A b A b
a a
R a R a
Prefix with strip, renames, creates etc Prefix with strip, renames, creates etc
$ hg revert -aC $ hg revert -aC
undeleting a
forgetting b forgetting b
undeleting a
$ rm b $ rm b
$ mkdir -p dir/dir2 $ mkdir -p dir/dir2
$ echo b > dir/dir2/b $ echo b > dir/dir2/b
$ echo c > dir/dir2/c $ echo c > dir/dir2/c
$ echo d > dir/d $ echo d > dir/d
$ hg ci -Am addbcd $ hg ci -Am addbcd
adding dir/d adding dir/d
adding dir/dir2/b adding dir/dir2/b
R dir/d R dir/d
R dir/dir2/b R dir/dir2/b
$ cd .. $ cd ..
Renames, similarity and git diff Renames, similarity and git diff
$ hg revert -aC $ hg revert -aC
forgetting dir/a forgetting dir/a
undeleting dir/d
undeleting dir/dir2/b
forgetting dir/dir2/b2 forgetting dir/dir2/b2
reverting dir/dir2/c reverting dir/dir2/c
undeleting dir/d
undeleting dir/dir2/b
$ rm dir/a dir/dir2/b2 $ rm dir/a dir/dir2/b2
$ hg import --similarity 90 --no-commit - <<EOF $ hg import --similarity 90 --no-commit - <<EOF
> diff --git a/a b/b > diff --git a/a b/b
> rename from a > rename from a
> rename to b > rename to b
> EOF > EOF
applying patch from stdin applying patch from stdin
$ hg st --copies $ hg st --copies

tests/test-import.t

recording removal of a as rename to b (88% similar) recording removal of a as rename to b (88% similar)
applied to working directory applied to working directory
$ echo 'mod b' > b $ echo 'mod b' > b
$ hg st -C $ hg st -C
A b A b
a a
R a R a
$ hg revert -a $ hg revert -a
undeleting a
forgetting b forgetting b
undeleting a
$ cat b $ cat b
mod b mod b
$ rm b $ rm b
$ hg import --no-commit -v -s 100 ../rename.diff -p2 $ hg import --no-commit -v -s 100 ../rename.diff -p2
applying ../rename.diff applying ../rename.diff
patching file a patching file a
patching file b patching file b
adding b adding b

tests/test-issue660.t

$ rm -r a b $ rm -r a b
$ hg revert b/b $ hg revert b/b
abort: file 'b' in dirstate clashes with 'b/b' abort: file 'b' in dirstate clashes with 'b/b'
[255] [255]
Revert all - should succeed: Revert all - should succeed:
$ hg revert --all $ hg revert --all
undeleting a
forgetting a/a forgetting a/a
forgetting b forgetting b
undeleting a
undeleting b/b undeleting b/b
$ hg st $ hg st
Issue3423: Issue3423:
$ hg forget a $ hg forget a
$ echo zed > a $ echo zed > a

tests/test-largefiles-misc.t

$ echo 'modified' > dir/subdir2/large.bin $ echo 'modified' > dir/subdir2/large.bin
$ hg status -C $ hg status -C
A dir/subdir2/large.bin A dir/subdir2/large.bin
dir/subdir/large.bin dir/subdir/large.bin
R dir/subdir/large.bin R dir/subdir/large.bin
? large.orig ? large.orig
$ hg revert --all $ hg revert --all
undeleting .hglf/dir/subdir/large.bin
forgetting .hglf/dir/subdir2/large.bin forgetting .hglf/dir/subdir2/large.bin
undeleting .hglf/dir/subdir/large.bin
reverting subrepo no-largefiles reverting subrepo no-largefiles
$ hg status -C $ hg status -C
? dir/subdir2/large.bin ? dir/subdir2/large.bin
? large.orig ? large.orig
The content of the forgotten file shouldn't be clobbered The content of the forgotten file shouldn't be clobbered
.hglf/dir2/subdir/large.bin .hglf/dir2/subdir/large.bin
.hglf/large .hglf/large
dir2/ dir2/
dir2/subdir/ dir2/subdir/
dir2/subdir/large.bin dir2/subdir/large.bin
large large
$ hg revert --all $ hg revert --all
undeleting .hglf/dir/subdir/large.bin
forgetting .hglf/dir2/subdir/large.bin forgetting .hglf/dir2/subdir/large.bin
undeleting .hglf/dir/subdir/large.bin
reverting subrepo no-largefiles reverting subrepo no-largefiles
$ hg status -C $ hg status -C
? dir2/subdir/large.bin ? dir2/subdir/large.bin
$ $PYTHON $TESTDIR/list-tree.py .hglf dir* large* $ $PYTHON $TESTDIR/list-tree.py .hglf dir* large*
.hglf/ .hglf/
.hglf/dir/ .hglf/dir/

tests/test-largefiles.t

R sub2/large6 R sub2/large6
? sub/large4.orig ? sub/large4.orig
? sub/normal4.orig ? sub/normal4.orig
$ cat sub/normal4 $ cat sub/normal4
normal4-modified normal4-modified
$ cat sub/large4 $ cat sub/large4
large4-modified large4-modified
$ hg revert -a --no-backup $ hg revert -a --no-backup
undeleting .hglf/sub2/large6
forgetting .hglf/sub2/large8 forgetting .hglf/sub2/large8
reverting normal3 reverting normal3
undeleting .hglf/sub2/large6
$ hg status $ hg status
? sub/large4.orig ? sub/large4.orig
? sub/normal4.orig ? sub/normal4.orig
? sub2/large8 ? sub2/large8
$ cat normal3 $ cat normal3
normal3-modified normal3-modified
$ cat sub2/large6 $ cat sub2/large6
large6-modified large6-modified

tests/test-lfs-test-server.t

Revert will prefetch blobs in a group Revert will prefetch blobs in a group
$ rm -rf .hg/store/lfs $ rm -rf .hg/store/lfs
$ rm -rf `hg config lfs.usercache` $ rm -rf `hg config lfs.usercache`
$ rm * $ rm *
$ hg revert --all -r 1 --debug $ hg revert --all -r 1 --debug
http auth: user foo, password *** http auth: user foo, password ***
adding a
reverting b
reverting c
reverting d
http auth: user foo, password *** http auth: user foo, password ***
Status: 200 Status: 200
Content-Length: 905 (git-server !) Content-Length: 905 (git-server !)
Content-Length: 988 (hg-server !) Content-Length: 988 (hg-server !)
Content-Type: application/vnd.git-lfs+json Content-Type: application/vnd.git-lfs+json
Date: $HTTP_DATE$ Date: $HTTP_DATE$
Server: testing stub value (hg-server !) Server: testing stub value (hg-server !)
{ {
Content-Length: 19 Content-Length: 19
Content-Type: text/plain; charset=utf-8 (git-server !) Content-Type: text/plain; charset=utf-8 (git-server !)
Content-Type: application/octet-stream (hg-server !) Content-Type: application/octet-stream (hg-server !)
Date: $HTTP_DATE$ Date: $HTTP_DATE$
Server: testing stub value (hg-server !) Server: testing stub value (hg-server !)
lfs: adding d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 to the usercache lfs: adding d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 to the usercache
lfs: processed: d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 lfs: processed: d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998
lfs: downloaded 3 files (51 bytes) lfs: downloaded 3 files (51 bytes)
reverting b
lfs: found 31cf46fbc4ecd458a0943c5b4881f1f5a6dd36c53d6167d5b69ac45149b38e5b in the local lfs store lfs: found 31cf46fbc4ecd458a0943c5b4881f1f5a6dd36c53d6167d5b69ac45149b38e5b in the local lfs store
reverting c
lfs: found d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 in the local lfs store lfs: found d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 in the local lfs store
reverting d
lfs: found 37a65ab78d5ecda767e8622c248b5dbff1e68b1678ab0e730d5eb8601ec8ad19 in the local lfs store lfs: found 37a65ab78d5ecda767e8622c248b5dbff1e68b1678ab0e730d5eb8601ec8ad19 in the local lfs store
adding a
lfs: found 31cf46fbc4ecd458a0943c5b4881f1f5a6dd36c53d6167d5b69ac45149b38e5b in the local lfs store lfs: found 31cf46fbc4ecd458a0943c5b4881f1f5a6dd36c53d6167d5b69ac45149b38e5b in the local lfs store
Check error message when the remote missed a blob: Check error message when the remote missed a blob:
$ echo FFFFF > b $ echo FFFFF > b
$ hg commit -m b -A b $ hg commit -m b -A b
$ echo FFFFF >> b $ echo FFFFF >> b
$ hg commit -m b b $ hg commit -m b b

tests/test-merge-remove.t

M foo1 M foo1
foo foo
Reverting foo1 and bar: Reverting foo1 and bar:
$ hg revert -vr . foo1 bar $ hg revert -vr . foo1 bar
saving current version of bar as bar.orig saving current version of bar as bar.orig
reverting bar
saving current version of foo1 as foo1.orig saving current version of foo1 as foo1.orig
reverting bar
reverting foo1 reverting foo1
$ hg debugstate --nodates $ hg debugstate --nodates
n 0 -2 unset bar n 0 -2 unset bar
n 0 -2 unset foo1 n 0 -2 unset foo1
copy: foo -> foo1 copy: foo -> foo1
$ hg st -qC $ hg st -qC

tests/test-revert-interactive.t

> y > y
> y > y
> y > y
> ? > ?
> y > y
> n > n
> n > n
> EOF > EOF
reverting f
reverting folder1/g
removing folder1/i
reverting folder2/h
remove added file folder1/i (Yn)? y remove added file folder1/i (Yn)? y
removing folder1/i
diff --git a/f b/f diff --git a/f b/f
2 hunks, 2 lines changed 2 hunks, 2 lines changed
examine changes to 'f'? [Ynesfdaq?] y examine changes to 'f'? [Ynesfdaq?] y
@@ -1,6 +1,5 @@ @@ -1,6 +1,5 @@
-a -a
1 1
2 2
5 5
-d -d
apply change 4/6 to 'folder1/g'? [Ynesfdaq?] n apply change 4/6 to 'folder1/g'? [Ynesfdaq?] n
diff --git a/folder2/h b/folder2/h diff --git a/folder2/h b/folder2/h
2 hunks, 2 lines changed 2 hunks, 2 lines changed
examine changes to 'folder2/h'? [Ynesfdaq?] n examine changes to 'folder2/h'? [Ynesfdaq?] n
reverting folder1/g
reverting f
$ cat f $ cat f
1 1
2 2
3 3
4 4
5 5
$ cat folder1/g $ cat folder1/g
1 1
3 3
4 4
5 5
f f
Test that --interactive lift the need for --all Test that --interactive lift the need for --all
$ echo q | hg revert -i -r 2 $ echo q | hg revert -i -r 2
reverting folder1/g
reverting folder2/h
diff --git a/folder1/g b/folder1/g diff --git a/folder1/g b/folder1/g
1 hunks, 1 lines changed 1 hunks, 1 lines changed
examine changes to 'folder1/g'? [Ynesfdaq?] q examine changes to 'folder1/g'? [Ynesfdaq?] q
abort: user quit abort: user quit
[255] [255]
$ ls folder1/ $ ls folder1/
g g
> y > y
> y > y
> y > y
> y > y
> y > y
> n > n
> n > n
> EOF > EOF
reverting f
reverting folder1/g
removing folder1/i
reverting folder2/h
remove added file folder1/i (Yn)? n remove added file folder1/i (Yn)? n
diff --git a/f b/f diff --git a/f b/f
2 hunks, 2 lines changed 2 hunks, 2 lines changed
examine changes to 'f'? [Ynesfdaq?] y examine changes to 'f'? [Ynesfdaq?] y
@@ -1,6 +1,5 @@ @@ -1,6 +1,5 @@
-a -a
1 1
5 5
-d -d
apply change 4/6 to 'folder1/g'? [Ynesfdaq?] n apply change 4/6 to 'folder1/g'? [Ynesfdaq?] n
diff --git a/folder2/h b/folder2/h diff --git a/folder2/h b/folder2/h
2 hunks, 2 lines changed 2 hunks, 2 lines changed
examine changes to 'folder2/h'? [Ynesfdaq?] n examine changes to 'folder2/h'? [Ynesfdaq?] n
reverting folder1/g
reverting f
$ cat f $ cat f
1 1
2 2
3 3
4 4
5 5
$ cat folder1/g $ cat folder1/g
1 1
$ hg commit -m "add k" $ hg commit -m "add k"
3) Use interactive revert with editing (replacing +1 with +42): 3) Use interactive revert with editing (replacing +1 with +42):
$ printf "0\n2\n" > k $ printf "0\n2\n" > k
$ HGEDITOR="\"sh\" \"${TESTTMP}/editor.sh\"" hg revert -i <<EOF $ HGEDITOR="\"sh\" \"${TESTTMP}/editor.sh\"" hg revert -i <<EOF
> y > y
> e > e
> EOF > EOF
reverting k
diff --git a/k b/k diff --git a/k b/k
1 hunks, 2 lines changed 1 hunks, 2 lines changed
examine changes to 'k'? [Ynesfdaq?] y examine changes to 'k'? [Ynesfdaq?] y
@@ -1,1 +1,2 @@ @@ -1,1 +1,2 @@
-1 -1
+0 +0
+2 +2
discard this change to 'k'? [Ynesfdaq?] e discard this change to 'k'? [Ynesfdaq?] e
reverting k
$ cat k $ cat k
42 42
$ hg update -C . $ hg update -C .
1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg purge $ hg purge
$ touch newfile $ touch newfile
$ hg add newfile $ hg add newfile
$ hg status $ hg status
A newfile A newfile
$ hg revert -i <<EOF $ hg revert -i <<EOF
> n > n
> EOF > EOF
forgetting newfile
forget added file newfile (Yn)? n forget added file newfile (Yn)? n
$ hg status $ hg status
A newfile A newfile
$ hg revert -i <<EOF $ hg revert -i <<EOF
> y > y
> EOF > EOF
forgetting newfile
forget added file newfile (Yn)? y forget added file newfile (Yn)? y
forgetting newfile
$ hg status $ hg status
? newfile ? newfile
When a line without EOL is selected during "revert -i" (issue5651) When a line without EOL is selected during "revert -i" (issue5651)
$ hg init $TESTTMP/revert-i-eol $ hg init $TESTTMP/revert-i-eol
$ cd $TESTTMP/revert-i-eol $ cd $TESTTMP/revert-i-eol
$ echo 0 > a $ echo 0 > a
$ hg ci -qAm 0 $ hg ci -qAm 0
$ printf 1 >> a $ printf 1 >> a
$ hg ci -qAm 1 $ hg ci -qAm 1
$ cat a $ cat a
0 0
1 (no-eol) 1 (no-eol)
$ hg revert -ir'.^' <<EOF $ hg revert -ir'.^' <<EOF
> y > y
> y > y
> EOF > EOF
reverting a
diff --git a/a b/a diff --git a/a b/a
1 hunks, 1 lines changed 1 hunks, 1 lines changed
examine changes to 'a'? [Ynesfdaq?] y examine changes to 'a'? [Ynesfdaq?] y
@@ -1,2 +1,1 @@ @@ -1,2 +1,1 @@
0 0
-1 -1
\ No newline at end of file \ No newline at end of file
apply this change to 'a'? [Ynesfdaq?] y apply this change to 'a'? [Ynesfdaq?] y
reverting a
$ cat a $ cat a
0 0
When specified pattern does not exist, we should exit early (issue5789). When specified pattern does not exist, we should exit early (issue5789).
$ hg files $ hg files
a a
$ hg rev b $ hg rev b
b: no such file in rev b40d1912accf b: no such file in rev b40d1912accf
$ hg rev -i b $ hg rev -i b
b: no such file in rev b40d1912accf b: no such file in rev b40d1912accf
$ cd .. $ cd ..

tests/test-revert.t

$ hg st $ hg st
A z A z
? e.orig ? e.orig
revert to another revision (--rev) revert to another revision (--rev)
---------------------------------- ----------------------------------
$ hg revert --all -r0 $ hg revert --all -r0
adding a
removing d
forgetting z forgetting z
removing d
adding a
revert explicitly to parent (--rev) revert explicitly to parent (--rev)
----------------------------------- -----------------------------------
$ hg revert --all -rtip $ hg revert --all -rtip
forgetting a forgetting a
undeleting d undeleting d
$ rm a *.orig $ rm a *.orig
$ hg ci -A -m b $ hg ci -A -m b
adding b/b adding b/b
created new head created new head
$ echo foobar > b/b $ echo foobar > b/b
$ mkdir newdir $ mkdir newdir
$ echo foo > newdir/newfile $ echo foo > newdir/newfile
$ hg add newdir/newfile $ hg add newdir/newfile
$ hg revert b newdir $ hg revert b newdir
reverting b/b
forgetting newdir/newfile forgetting newdir/newfile
reverting b/b
$ echo foobar > b/b $ echo foobar > b/b
$ hg revert . $ hg revert .
reverting b/b reverting b/b
reverting a rename target should revert the source reverting a rename target should revert the source
-------------------------------------------------- --------------------------------------------------
$ hg copy removed base $ hg copy removed base
$ hg commit -m rename $ hg commit -m rename
copies and renames, you have no chance to survive make your time (issue3920) copies and renames, you have no chance to survive make your time (issue3920)
$ hg update '.^' $ hg update '.^'
1 files updated, 0 files merged, 2 files removed, 0 files unresolved 1 files updated, 0 files merged, 2 files removed, 0 files unresolved
$ hg revert -rtip -a $ hg revert -rtip -a
removing ignored
adding allyour adding allyour
adding base adding base
removing ignored
$ hg status -C $ hg status -C
A allyour A allyour
ignored ignored
A base A base
removed removed
R ignored R ignored
Test revert of a file added by one side of the merge Test revert of a file added by one side of the merge
(setup from reference repo) (setup from reference repo)
$ cp -R revert-ref revert-parent-all $ cp -R revert-ref revert-parent-all
$ cd revert-parent-all $ cd revert-parent-all
check revert output check revert output
$ hg revert --all $ hg revert --all
undeleting content1_content1_content1-untracked forgetting content1_missing_content1-tracked
forgetting content1_missing_content3-tracked
forgetting content1_missing_missing-tracked
forgetting missing_missing_content3-tracked
forgetting missing_missing_missing-tracked
reverting content1_content1_content3-tracked reverting content1_content1_content3-tracked
undeleting content1_content1_content3-untracked
reverting content1_content1_missing-tracked reverting content1_content1_missing-tracked
undeleting content1_content1_missing-untracked
reverting content1_content2_content1-tracked reverting content1_content2_content1-tracked
reverting content1_content2_content3-tracked
reverting content1_content2_missing-tracked
reverting missing_content2_content3-tracked
reverting missing_content2_missing-tracked
undeleting content1_content1_content1-untracked
undeleting content1_content1_content3-untracked
undeleting content1_content1_missing-untracked
undeleting content1_content2_content1-untracked undeleting content1_content2_content1-untracked
undeleting content1_content2_content2-untracked undeleting content1_content2_content2-untracked
reverting content1_content2_content3-tracked
undeleting content1_content2_content3-untracked undeleting content1_content2_content3-untracked
reverting content1_content2_missing-tracked
undeleting content1_content2_missing-untracked undeleting content1_content2_missing-untracked
forgetting content1_missing_content1-tracked
forgetting content1_missing_content3-tracked
forgetting content1_missing_missing-tracked
undeleting missing_content2_content2-untracked undeleting missing_content2_content2-untracked
reverting missing_content2_content3-tracked
undeleting missing_content2_content3-untracked undeleting missing_content2_content3-untracked
reverting missing_content2_missing-tracked
undeleting missing_content2_missing-untracked undeleting missing_content2_missing-untracked
forgetting missing_missing_content3-tracked
forgetting missing_missing_missing-tracked
Compare resulting directory with revert target. Compare resulting directory with revert target.
The diff is filtered to include change only. The only difference should be The diff is filtered to include change only. The only difference should be
additional `.orig` backup file when applicable. additional `.orig` backup file when applicable.
$ $PYTHON ../dircontent.py > ../content-parent-all.txt $ $PYTHON ../dircontent.py > ../content-parent-all.txt
$ cd .. $ cd ..
(setup from reference repo) (setup from reference repo)
$ cp -R revert-ref revert-base-all $ cp -R revert-ref revert-base-all
$ cd revert-base-all $ cd revert-base-all
check revert output check revert output
$ hg revert --all --rev 'desc(base)' $ hg revert --all --rev 'desc(base)'
undeleting content1_content1_content1-untracked forgetting missing_missing_content3-tracked
forgetting missing_missing_missing-tracked
removing missing_content2_content2-tracked
removing missing_content2_content3-tracked
removing missing_content2_missing-tracked
reverting content1_content1_content3-tracked reverting content1_content1_content3-tracked
undeleting content1_content1_content3-untracked
reverting content1_content1_missing-tracked reverting content1_content1_missing-tracked
undeleting content1_content1_missing-untracked
undeleting content1_content2_content1-untracked
reverting content1_content2_content2-tracked reverting content1_content2_content2-tracked
undeleting content1_content2_content2-untracked
reverting content1_content2_content3-tracked reverting content1_content2_content3-tracked
undeleting content1_content2_content3-untracked
reverting content1_content2_missing-tracked reverting content1_content2_missing-tracked
undeleting content1_content2_missing-untracked
adding content1_missing_content1-untracked
reverting content1_missing_content3-tracked reverting content1_missing_content3-tracked
adding content1_missing_content3-untracked
reverting content1_missing_missing-tracked reverting content1_missing_missing-tracked
adding content1_missing_content1-untracked
adding content1_missing_content3-untracked
adding content1_missing_missing-untracked adding content1_missing_missing-untracked
removing missing_content2_content2-tracked undeleting content1_content1_content1-untracked
removing missing_content2_content3-tracked undeleting content1_content1_content3-untracked
removing missing_content2_missing-tracked undeleting content1_content1_missing-untracked
forgetting missing_missing_content3-tracked undeleting content1_content2_content1-untracked
forgetting missing_missing_missing-tracked undeleting content1_content2_content2-untracked
undeleting content1_content2_content3-untracked
undeleting content1_content2_missing-untracked
Compare resulting directory with revert target. Compare resulting directory with revert target.
The diff is filtered to include change only. The only difference should be The diff is filtered to include change only. The only difference should be
additional `.orig` backup file when applicable. additional `.orig` backup file when applicable.
$ $PYTHON ../dircontent.py > ../content-base-all.txt $ $PYTHON ../dircontent.py > ../content-base-all.txt
$ cd .. $ cd ..
$ hg status --rev 'p1()' $ hg status --rev 'p1()'
M A M A
$ hg status --rev 'p2()' $ hg status --rev 'p2()'
A B A B
$ hg status --rev '1' $ hg status --rev '1'
M A M A
A B A B
$ hg revert --rev 1 --all $ hg revert --rev 1 --all
reverting A
removing B removing B
reverting A
$ hg status --rev 1 $ hg status --rev 1
From the other parents From the other parents
$ hg up -C 'p2()' $ hg up -C 'p2()'
1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg merge $ hg merge
1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
(branch merge, don't forget to commit) (branch merge, don't forget to commit)
$ hg status --rev 'p1()' $ hg status --rev 'p1()'
M B M B
$ hg status --rev 'p2()' $ hg status --rev 'p2()'
A A A A
$ hg status --rev '1' $ hg status --rev '1'
M A M A
A B A B
$ hg revert --rev 1 --all $ hg revert --rev 1 --all
reverting A
removing B removing B
reverting A
$ hg status --rev 1 $ hg status --rev 1
$ cd .. $ cd ..