( )⚙ D4413 tests: remove use of string in CBOR test

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4413

tests: remove use of string in CBOR test
ClosedPublic

Authored by indygreg on Aug 28 2018, 11:29 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGfcc6bd11444b: tests: remove use of string in CBOR test
Summary

We don't use the CBOR string major type in the wire protocol. Let's
not test for it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 28 2018, 11:29 PM
Closed by commit rHGfcc6bd11444b: tests: remove use of string in CBOR test (authored by indygreg). · Explain WhySep 3 2018, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-wireproto-framing.py (3 lines)

Diff 10727

tests/test-wireproto-framing.py

self.assertEqual(ffs(b'1 1 0 1 0 cbor:-342542'), self.assertEqual(ffs(b'1 1 0 1 0 cbor:-342542'),
b'\x05\x00\x00\x01\x00\x01\x00\x10:\x00\x05:\r') b'\x05\x00\x00\x01\x00\x01\x00\x10:\x00\x05:\r')
def testcborstrings(self): def testcborstrings(self):
self.assertEqual(ffs(b"1 1 0 1 0 cbor:b'foo'"), self.assertEqual(ffs(b"1 1 0 1 0 cbor:b'foo'"),
b'\x04\x00\x00\x01\x00\x01\x00\x10Cfoo') b'\x04\x00\x00\x01\x00\x01\x00\x10Cfoo')
self.assertEqual(ffs(b"1 1 0 1 0 cbor:u'foo'"),
b'\x04\x00\x00\x01\x00\x01\x00\x10cfoo')
def testcborlists(self): def testcborlists(self):
self.assertEqual(ffs(b"1 1 0 1 0 cbor:[None, True, False, 42, b'foo']"), self.assertEqual(ffs(b"1 1 0 1 0 cbor:[None, True, False, 42, b'foo']"),
b'\n\x00\x00\x01\x00\x01\x00\x10\x85\xf6\xf5\xf4' b'\n\x00\x00\x01\x00\x01\x00\x10\x85\xf6\xf5\xf4'
b'\x18*Cfoo') b'\x18*Cfoo')
def testcbordicts(self): def testcbordicts(self):
self.assertEqual(ffs(b"1 1 0 1 0 " self.assertEqual(ffs(b"1 1 0 1 0 "
b"cbor:{b'foo': b'val1', b'bar': b'val2'}"), b"cbor:{b'foo': b'val1', b'bar': b'val2'}"),