This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4487

wireprotov2: add TODOs around extending changesetdata fields
ClosedPublic

Authored by indygreg on Sep 5 2018, 12:20 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG399ddd3227a4: wireprotov2: add TODOs around extending changesetdata fields
Summary

Extensions will inevitably want to extend the set of changeset
data/fields that can be requested. We'll need to implement support
for extending this in the future. Add some TODOs to track that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 5 2018, 12:20 PM
durin42 accepted this revision.Sep 12 2018, 11:15 AM
This revision is now accepted and ready to land.Sep 12 2018, 11:15 AM
Closed by commit rHG399ddd3227a4: wireprotov2: add TODOs around extending changesetdata fields (authored by indygreg). · Explain WhySep 14 2018, 11:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11065

mercurial/exchangev2.py

node = cset[b'node'] node = cset[b'node']
if b'phase' in cset: if b'phase' in cset:
nodesbyphase[cset[b'phase']].add(node) nodesbyphase[cset[b'phase']].add(node)
for mark in cset.get(b'bookmarks', []): for mark in cset.get(b'bookmarks', []):
remotebookmarks[mark] = node remotebookmarks[mark] = node
# TODO add mechanism for extensions to examine records so they
# can siphon off custom data fields.
# Some entries might only be metadata only updates. # Some entries might only be metadata only updates.
if b'revisionsize' not in cset: if b'revisionsize' not in cset:
continue continue
data = next(objs) data = next(objs)
yield ( yield (
node, node,

mercurial/wireprotov2server.py

}) })
caps = { caps = {
'commands': {}, 'commands': {},
'compression': compression, 'compression': compression,
'framingmediatypes': [FRAMINGTYPE], 'framingmediatypes': [FRAMINGTYPE],
} }
# TODO expose available changesetdata fields.
for command, entry in COMMANDS.items(): for command, entry in COMMANDS.items():
caps['commands'][command] = { caps['commands'][command] = {
'args': entry.args, 'args': entry.args,
'permissions': [entry.permission], 'permissions': [entry.permission],
} }
if streamclone.allowservergeneration(repo): if streamclone.allowservergeneration(repo):
caps['rawrepoformats'] = sorted(repo.requirements & caps['rawrepoformats'] = sorted(repo.requirements &
'noderange': [[b'0123456...'], [b'abcdef...']], 'noderange': [[b'0123456...'], [b'abcdef...']],
'nodes': [b'0123456...'], 'nodes': [b'0123456...'],
'fields': {b'parents', b'revision'}, 'fields': {b'parents', b'revision'},
}, },
permission='pull') permission='pull')
def changesetdata(repo, proto, noderange=None, nodes=None, fields=None): def changesetdata(repo, proto, noderange=None, nodes=None, fields=None):
fields = fields or set() fields = fields or set()
# TODO look for unknown fields and abort when they can't be serviced.
if noderange is None and nodes is None: if noderange is None and nodes is None:
raise error.WireprotoCommandError( raise error.WireprotoCommandError(
'noderange or nodes must be defined') 'noderange or nodes must be defined')
if noderange is not None: if noderange is not None:
if len(noderange) != 2: if len(noderange) != 2:
raise error.WireprotoCommandError( raise error.WireprotoCommandError(
'noderange must consist of 2 elements') 'noderange must consist of 2 elements')
del nodebookmarks[node] del nodebookmarks[node]
revisiondata = None revisiondata = None
if b'revision' in fields: if b'revision' in fields:
revisiondata = cl.revision(node, raw=True) revisiondata = cl.revision(node, raw=True)
d[b'revisionsize'] = len(revisiondata) d[b'revisionsize'] = len(revisiondata)
# TODO make it possible for extensions to wrap a function or register
# a handler to service custom fields.
yield d yield d
if revisiondata is not None: if revisiondata is not None:
yield revisiondata yield revisiondata
# If requested, send bookmarks from nodes that didn't have revision # If requested, send bookmarks from nodes that didn't have revision
# data sent so receiver is aware of any bookmark updates. # data sent so receiver is aware of any bookmark updates.
if b'bookmarks' in fields: if b'bookmarks' in fields: