This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4435

wireprotov2peer: add TODO about streaming responses
ClosedPublic

Authored by indygreg on Aug 31 2018, 6:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1467b6c27ff9: wireprotov2peer: add TODO about streaming responses
Summary

This is a pretty big deficiency in the current implementation.
We don't want to forget about this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotov2peer.py (3 lines)

Diff 10756

mercurial/wireprotov2peer.py

raise error.ProgrammingError( raise error.ProgrammingError(
'received frame for unknown request; this is either a bug in ' 'received frame for unknown request; this is either a bug in '
'the clientreactor not screening for this or this instance was ' 'the clientreactor not screening for this or this instance was '
'never told about this request: %r' % frame) 'never told about this request: %r' % frame)
response = self._responses[frame.requestid] response = self._responses[frame.requestid]
if action == 'responsedata': if action == 'responsedata':
# This buffers all data until end of stream is received. This
# is bad for performance.
# TODO make response data streamable
response.b.write(meta['data']) response.b.write(meta['data'])
if meta['eos']: if meta['eos']:
# If the command has a decoder, resolve the future to the # If the command has a decoder, resolve the future to the
# decoded value. Otherwise resolve to the rich response object. # decoded value. Otherwise resolve to the rich response object.
decoder = COMMAND_DECODERS.get(response.command) decoder = COMMAND_DECODERS.get(response.command)
# TODO consider always resolving the overall status map. # TODO consider always resolving the overall status map.