This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4438

httppeer: add TODO about delayed handling of ^C
ClosedPublic

Authored by indygreg on Aug 31 2018, 6:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3c6f7eebc010: httppeer: add TODO about delayed handling of ^C
Summary

When testing wire protocol v2 with large responses, I noticed that
^C doesn't result in immediate termination. I'm not sure what the
root cause is. Let's add a TODO so we don't forget about it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 31 2018, 6:57 PM
pulkit accepted this revision.Sep 4 2018, 1:43 PM
Closed by commit rHG3c6f7eebc010: httppeer: add TODO about delayed handling of ^C (authored by indygreg). · Explain WhySep 4 2018, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/httppeer.py (2 lines)

Diff 10758

mercurial/httppeer.py

self.sendcommands() self.sendcommands()
self._closed = True self._closed = True
if not self._responsef: if not self._responsef:
return return
# TODO ^C here may not result in immediate program termination.
try: try:
self._responsef.result() self._responsef.result()
finally: finally:
self._responseexecutor.shutdown(wait=True) self._responseexecutor.shutdown(wait=True)
self._responsef = None self._responsef = None
self._responseexecutor = None self._responseexecutor = None
# If any of our futures are still in progress, mark them as # If any of our futures are still in progress, mark them as