This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4852

localrepo: add repository feature when repo can be stream cloned
ClosedPublic

Authored by indygreg on Oct 3 2018, 12:51 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG83146d176c03: localrepo: add repository feature when repo can be stream cloned
Summary

Right now, the wire protocol server assumes all repository objects can
be stream cloned (unless the stream clone feature is disabled via
config option).

But not all storage backends or repository objects may support stream
clone.

This commit defines a repository feature denoting whether stream clone
is supported. The feature is defined for revlog-based repositories,
which should currently be "all repositories."

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (1 line)
Mmercurial/repository.py (2 lines)

Diff 11630

mercurial/localrepo.py

if path[0] == b'/': if path[0] == b'/':
path = path[1:] path = path[1:]
return filelog.narrowfilelog(self.svfs, path, self.narrowmatch()) return filelog.narrowfilelog(self.svfs, path, self.narrowmatch())
def makefilestorage(requirements, features, **kwargs): def makefilestorage(requirements, features, **kwargs):
"""Produce a type conforming to ``ilocalrepositoryfilestorage``.""" """Produce a type conforming to ``ilocalrepositoryfilestorage``."""
features.add(repository.REPO_FEATURE_REVLOG_FILE_STORAGE) features.add(repository.REPO_FEATURE_REVLOG_FILE_STORAGE)
features.add(repository.REPO_FEATURE_STREAM_CLONE)
if repository.NARROW_REQUIREMENT in requirements: if repository.NARROW_REQUIREMENT in requirements:
return revlognarrowfilestorage return revlognarrowfilestorage
else: else:
return revlogfilestorage return revlogfilestorage
# List of repository interfaces and factory functions for them. Each # List of repository interfaces and factory functions for them. Each
# will be called in order during ``makelocalrepository()`` to iteratively # will be called in order during ``makelocalrepository()`` to iteratively

mercurial/repository.py

# Local repository feature string. # Local repository feature string.
# Revlogs are being used for file storage. # Revlogs are being used for file storage.
REPO_FEATURE_REVLOG_FILE_STORAGE = b'revlogfilestorage' REPO_FEATURE_REVLOG_FILE_STORAGE = b'revlogfilestorage'
# The storage part of the repository is shared from an external source. # The storage part of the repository is shared from an external source.
REPO_FEATURE_SHARED_STORAGE = b'sharedstore' REPO_FEATURE_SHARED_STORAGE = b'sharedstore'
# LFS supported for backing file storage. # LFS supported for backing file storage.
REPO_FEATURE_LFS = b'lfs' REPO_FEATURE_LFS = b'lfs'
# Repository supports being stream cloned.
REPO_FEATURE_STREAM_CLONE = b'streamclone'
class ipeerconnection(interfaceutil.Interface): class ipeerconnection(interfaceutil.Interface):
"""Represents a "connection" to a repository. """Represents a "connection" to a repository.
This is the base interface for representing a connection to a repository. This is the base interface for representing a connection to a repository.
It holds basic properties and methods applicable to all peer types. It holds basic properties and methods applicable to all peer types.
This is not a complete interface definition and should not be used This is not a complete interface definition and should not be used