This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5178

archive: use manifest.matches() to simplify and speed up matching
ClosedPublic

Authored by martinvonz on Oct 20 2018, 2:32 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5eefd32cb382: archive: use manifest.matches() to simplify and speed up matching
rHG8c124d10ae02: archive: use manifest.matches() to simplify and speed up matching
Summary

manifest.matches() can avoid walking paths the user did not want to
archive.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 20 2018, 2:32 PM
Closed by commit rHG8c124d10ae02: archive: use manifest.matches() to simplify and speed up matching (authored by martinvonz). · Explain WhyOct 22 2018, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/archival.py (2 lines)

Diff 12313

mercurial/archival.py

if not match: if not match:
match = scmutil.matchall(repo) match = scmutil.matchall(repo)
if repo.ui.configbool("ui", "archivemeta"): if repo.ui.configbool("ui", "archivemeta"):
name = '.hg_archival.txt' name = '.hg_archival.txt'
if match(name): if match(name):
write(name, 0o644, False, lambda: buildmetadata(ctx)) write(name, 0o644, False, lambda: buildmetadata(ctx))
files = [f for f in ctx.manifest().keys() if match(f)] files = [f for f in ctx.manifest().matches(match)]
total = len(files) total = len(files)
if total: if total:
files.sort() files.sort()
scmutil.prefetchfiles(repo, [ctx.rev()], scmutil.prefetchfiles(repo, [ctx.rev()],
scmutil.matchfiles(repo, files)) scmutil.matchfiles(repo, files))
progress = scmutil.progress(repo.ui, _('archiving'), unit=_('files'), progress = scmutil.progress(repo.ui, _('archiving'), unit=_('files'),
total=total) total=total)
progress.update(0) progress.update(0)