Page MenuHomePhabricator

phabricator: fallback to reading metadata from diff for phabread
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:53 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Apr 22 2019, 11:53 AM
Kwan edited the summary of this revision. (Show Details)Apr 22 2019, 1:57 PM
Kwan edited the summary of this revision. (Show Details)
Kwan updated this revision to Diff 14894.
Kwan added inline comments.Apr 22 2019, 2:08 PM
hgext/phabricator.py
926

I didn't use get here because "dateCreated" is set by conduit, not the submitted data, so should always be present and valid (but will make it get if requested).

martinvonz added inline comments.
hgext/phabricator.py
926

I'm not very good at using the phabricator interface, but it seems like this has been addressed since this line doesn't have a get. Can someone confirm?

926

Oh, sorry, Kwan is the author is this series :P So nothing needs to be done then.

This revision was automatically updated to reflect the committed changes.