This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6302

phabricator: include branch in the phabread output
ClosedPublic

Authored by Kwan on Apr 22 2019, 1:31 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG231334c1ee96: phabricator: include branch in the phabread output
Summary

Depends on D6301

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Apr 22 2019, 1:31 PM
Kwan edited the summary of this revision. (Show Details)Apr 22 2019, 1:57 PM
Kwan updated this revision to Diff 14895.
martinvonz added a subscriber: martinvonz.Apr 24 2019, 3:11 PM

This series looks reasonable to me, but I have no experience with this code. Anyone else feels like reviewing? Otherwise I'll probably just queue it in a day or two.

martinvonz added a comment.May 6 2019, 12:16 PM
In D6302#91773, @martinvonz wrote:

This series looks reasonable to me, but I have no experience with this code. Anyone else feels like reviewing? Otherwise I'll probably just queue it in a day or two.

... or twelve :P Sorry about that. I completely forgot about this series. I'll queue it now.

Closed by commit rHG231334c1ee96: phabricator: include branch in the phabread output (authored by Kwan). · Explain WhyMay 6 2019, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (3 lines)

Diff 15029

hgext/phabricator.py

date=None, local=True) date=None, local=True)
scmutil.cleanupnodes(repo, mapping, b'phabsend', fixphase=True) scmutil.cleanupnodes(repo, mapping, b'phabsend', fixphase=True)
if wnode in mapping: if wnode in mapping:
unfi.setparents(mapping[wnode][0]) unfi.setparents(mapping[wnode][0])
# Map from "hg:meta" keys to header understood by "hg import". The order is # Map from "hg:meta" keys to header understood by "hg import". The order is
# consistent with "hg export" output. # consistent with "hg export" output.
_metanamemap = util.sortdict([(b'user', b'User'), (b'date', b'Date'), _metanamemap = util.sortdict([(b'user', b'User'), (b'date', b'Date'),
(b'node', b'Node ID'), (b'parent', b'Parent ')]) (b'branch', b'Branch'), (b'node', b'Node ID'),
(b'parent', b'Parent ')])
def _confirmbeforesend(repo, revs, oldmap): def _confirmbeforesend(repo, revs, oldmap):
url, token = readurltoken(repo) url, token = readurltoken(repo)
ui = repo.ui ui = repo.ui
for rev in revs: for rev in revs:
ctx = repo[rev] ctx = repo[rev]
desc = ctx.description().splitlines()[0] desc = ctx.description().splitlines()[0]
oldnode, olddiff, drevid = oldmap.get(ctx.node(), (None, None, None)) oldnode, olddiff, drevid = oldmap.get(ctx.node(), (None, None, None))