phabricator: include branch in the diffproperty metadata
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:52 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Kwan created this revision.Apr 22 2019, 11:52 AM
pulkit added a subscriber: pulkit.Apr 22 2019, 12:03 PM

wow, does it work?

Kwan added a comment.Apr 22 2019, 2:03 PM
In D6297#91618, @pulkit wrote:

wow, does it work?

For future posterity, since I already replied to pulkit on IRC, this won't make Phab display the branch in the web UI anywhere (still need to use creatediff API for that), but D6302 makes phabread use this to include the branch in its hg importable output.

indygreg accepted this revision.Apr 24 2019, 10:12 PM
This revision is now accepted and ready to land.Apr 24 2019, 10:12 PM
pulkit accepted this revision.Thu, Apr 25, 1:37 PM
In D6297#91657, @Kwan wrote:
In D6297#91618, @pulkit wrote:

wow, does it work?

For future posterity, since I already replied to pulkit on IRC, this won't make Phab display the branch in the web UI anywhere (still need to use creatediff API for that), but D6302 makes phabread use this to include the branch in its hg importable output.

I have amended the commit to include the above info in commit description.

This revision was automatically updated to reflect the committed changes.