This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6300

phabricator: read more metadata from local:commits
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:52 AM.

Details

Reviewers
indygreg
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc4d96f4761d3: phabricator: read more metadata from local:commits
Summary

local:commits metadata can contain branch info, and 'rev' has been superseded
by 'commit', see:
https://github.com/phacility/arcanist/blob/83661809e532c3fe444a8bf7c7d6936e6377691b/src/repository/api/ArcanistMercurialAPI.php#L281

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Apr 22 2019, 11:52 AM
indygreg accepted this revision.Apr 24 2019, 10:13 PM
This revision is now accepted and ready to land.Apr 24 2019, 10:13 PM
pulkit accepted this revision.Apr 25 2019, 1:38 PM
Closed by commit rHGc4d96f4761d3: phabricator: read more metadata from local:commits (authored by Kwan). · Explain WhyApr 25 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (7 lines)

Diff 14922

hgext/phabricator.py

if not meta and props.get(b'local:commits'): if not meta and props.get(b'local:commits'):
commit = sorted(props[b'local:commits'].values())[0] commit = sorted(props[b'local:commits'].values())[0]
meta = {} meta = {}
if b'author' in commit and b'authorEmail' in commit: if b'author' in commit and b'authorEmail' in commit:
meta[b'user'] = b'%s <%s>' % (commit[b'author'], meta[b'user'] = b'%s <%s>' % (commit[b'author'],
commit[b'authorEmail']) commit[b'authorEmail'])
if b'time' in commit: if b'time' in commit:
meta[b'date'] = b'%d 0' % commit[b'time'] meta[b'date'] = b'%d 0' % commit[b'time']
if b'rev' in commit: if b'branch' in commit:
meta[b'node'] = commit[b'rev'] meta[b'branch'] = commit[b'branch']
node = commit.get(b'commit', commit.get(b'rev'))
if node:
meta[b'node'] = node
if len(commit.get(b'parents', ())) >= 1: if len(commit.get(b'parents', ())) >= 1:
meta[b'parent'] = commit[b'parents'][0] meta[b'parent'] = commit[b'parents'][0]
return meta or {} return meta or {}
def readpatch(repo, drevs, write): def readpatch(repo, drevs, write):
"""generate plain-text patch readable by 'hg import' """generate plain-text patch readable by 'hg import'
write is usually ui.write. drevs is what "querydrev" returns, results of write is usually ui.write. drevs is what "querydrev" returns, results of