Page MenuHomePhabricator

statecheck: added support for the statecheck.unfinishedstates
AbandonedPublic

Authored by taapas1128 on Jun 7 2019, 12:06 PM.

Details

Reviewers
durin42
martinvonz
Group Reviewers
hg-reviewers
Summary

This adds support of the new class state.statecheck
throughout core and extensions. This also removes the
previous method cmdutil.unfinishedstates and its API.

The results are shown in tests.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

taapas1128 created this revision.Jun 7 2019, 12:06 PM
martinvonz requested changes to this revision.Jun 8 2019, 10:47 AM
martinvonz added inline comments.
tests/test-histedit-no-change.t
171

Could your leave this change for a separate patch at the end (as I said before)? We try to separate refactoring from functional changes.

This revision now requires changes to proceed.Jun 8 2019, 10:47 AM
taapas1128 requested review of this revision.Jun 8 2019, 11:24 AM

@martinvonz Doing that would be kind of difficult because these changes are not due to refactoring but due to statecheck.hint() which is a unified function for generating hint messages. If I change the messages in accordance to cmdutil.unfinishedstates then this problem will be there in the in integration of STATES. If you still want it I can do that by removing statecheck.hint() completely and getting the messages from cmdutil.py. So should I do that ?

taapas1128 abandoned this revision.Jun 8 2019, 11:40 AM