This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6619

crecord: fix if -> elif when handling key presses
ClosedPublic

Authored by spectral on Jul 8 2019, 4:28 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3be6ff55095b: crecord: fix if -> elif when handling key presses
Summary

This shouldn't actually change any behavior, I only noticed it since I started
using KEY_UP in tests, and it was complaining when it got down to the ^L
handler that initscr hadn't been called yet.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jul 8 2019, 4:28 PM
pulkit accepted this revision.Jul 8 2019, 5:36 PM
This revision is now accepted and ready to land.Jul 8 2019, 5:36 PM
spectral added a commit: rHG3be6ff55095b: crecord: fix if -> elif when handling key presses.Jul 8 2019, 6:04 PM
Closed by commit rHG3be6ff55095b: crecord: fix if -> elif when handling key presses (authored by spectral). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/crecord.py (2 lines)

Diff 15820

mercurial/crecord.py

""" """
Perform actions based on pressed keys. Perform actions based on pressed keys.
Return true to exit the main loop. Return true to exit the main loop.
""" """
keypressed = pycompat.bytestr(keypressed) keypressed = pycompat.bytestr(keypressed)
if keypressed in ["k", "KEY_UP"]: if keypressed in ["k", "KEY_UP"]:
self.uparrowevent() self.uparrowevent()
if keypressed in ["K", "KEY_PPAGE"]: elif keypressed in ["K", "KEY_PPAGE"]:
self.uparrowshiftevent() self.uparrowshiftevent()
elif keypressed in ["j", "KEY_DOWN"]: elif keypressed in ["j", "KEY_DOWN"]:
self.downarrowevent() self.downarrowevent()
elif keypressed in ["J", "KEY_NPAGE"]: elif keypressed in ["J", "KEY_NPAGE"]:
self.downarrowshiftevent() self.downarrowshiftevent()
elif keypressed in ["l", "KEY_RIGHT"]: elif keypressed in ["l", "KEY_RIGHT"]:
self.rightarrowevent() self.rightarrowevent()
elif keypressed in ["h", "KEY_LEFT"]: elif keypressed in ["h", "KEY_LEFT"]: