This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6932

context: clarify the various mode in the filesremoved method
ClosedPublic

Authored by marmoute on Oct 1 2019, 8:32 AM.

Details

Reviewers
martinvonz
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG15badd621825: context: clarify the various mode in the filesremoved method
Summary

The previous code was compact but a bit dense. The new proposed code deal with
each mode separately, there are some duplicated lines, but the meaning of each
mode stand out.

One of the benefit it to make it simpler to add further mode in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (15 lines)

Diff 16752

mercurial/context.py

if filesadded is None: if filesadded is None:
filesadded = scmutil.computechangesetfilesadded(self) filesadded = scmutil.computechangesetfilesadded(self)
else: else:
filesadded = scmutil.computechangesetfilesadded(self) filesadded = scmutil.computechangesetfilesadded(self)
return filesadded return filesadded
def filesremoved(self): def filesremoved(self):
source = self._repo.ui.config('experimental', 'copies.read-from') source = self._repo.ui.config('experimental', 'copies.read-from')
if (source == 'changeset-only' or filesremoved = self._changeset.filesremoved
(source == 'compatibility' and if source == 'changeset-only':
self._changeset.filesremoved is not None)): if filesremoved is None:
return self._changeset.filesremoved or [] filesremoved = []
return scmutil.computechangesetfilesremoved(self) elif source == 'compatibility':
if filesremoved is None:
filesremoved = scmutil.computechangesetfilesremoved(self)
else:
filesremoved = scmutil.computechangesetfilesremoved(self)
return filesremoved
@propertycache @propertycache
def _copies(self): def _copies(self):
source = self._repo.ui.config('experimental', 'copies.read-from') source = self._repo.ui.config('experimental', 'copies.read-from')
p1copies = self._changeset.p1copies p1copies = self._changeset.p1copies
p2copies = self._changeset.p2copies p2copies = self._changeset.p2copies
# If config says to get copy metadata only from changeset, then return # If config says to get copy metadata only from changeset, then return
# that, defaulting to {} if there was no copy metadata. # that, defaulting to {} if there was no copy metadata.