This is an archive of the discontinued Mercurial Phabricator instance.

context: clarify the various mode in the filesadded method
ClosedPublic

Authored by marmoute on Oct 1 2019, 8:32 AM.

Details

Summary

The previous code was compact but a bit dense. The new proposed code deal with
each mode separately, there are some duplicated lines, but the meaning of each
mode stand out.

One of the benefit it to make it simpler to add further mode in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 1 2019, 8:32 AM
pulkit accepted this revision.Oct 1 2019, 10:35 AM
This revision is now accepted and ready to land.Oct 1 2019, 10:35 AM