( )⚙ D6931 context: clarify the various mode in the filesadded method

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6931

context: clarify the various mode in the filesadded method
ClosedPublic

Authored by marmoute on Oct 1 2019, 8:32 AM.

Details

Reviewers
martinvonz
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG008e74b34fb7: context: clarify the various mode in the filesadded method
Summary

The previous code was compact but a bit dense. The new proposed code deal with
each mode separately, there are some duplicated lines, but the meaning of each
mode stand out.

One of the benefit it to make it simpler to add further mode in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Oct 1 2019, 8:32 AM
pulkit accepted this revision.Oct 1 2019, 10:35 AM
This revision is now accepted and ready to land.Oct 1 2019, 10:35 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (17 lines)

Diff 16728

mercurial/context.py

return self._changeset.date return self._changeset.date
def files(self): def files(self):
return self._changeset.files return self._changeset.files
def filesmodified(self): def filesmodified(self):
modified = set(self.files()) modified = set(self.files())
modified.difference_update(self.filesadded()) modified.difference_update(self.filesadded())
modified.difference_update(self.filesremoved()) modified.difference_update(self.filesremoved())
return sorted(modified) return sorted(modified)
def filesadded(self): def filesadded(self):
source = self._repo.ui.config('experimental', 'copies.read-from') source = self._repo.ui.config('experimental', 'copies.read-from')
if (source == 'changeset-only' or filesadded = self._changeset.filesadded
(source == 'compatibility' and if source == 'changeset-only':
self._changeset.filesadded is not None)): if filesadded is None:
return self._changeset.filesadded or [] filesadded = []
return scmutil.computechangesetfilesadded(self) elif source == 'compatibility':
if filesadded is None:
filesadded = scmutil.computechangesetfilesadded(self)
else:
filesadded = scmutil.computechangesetfilesadded(self)
return filesadded
def filesremoved(self): def filesremoved(self):
source = self._repo.ui.config('experimental', 'copies.read-from') source = self._repo.ui.config('experimental', 'copies.read-from')
if (source == 'changeset-only' or if (source == 'changeset-only' or
(source == 'compatibility' and (source == 'compatibility' and
self._changeset.filesremoved is not None)): self._changeset.filesremoved is not None)):
return self._changeset.filesremoved or [] return self._changeset.filesremoved or []
return scmutil.computechangesetfilesremoved(self) return scmutil.computechangesetfilesremoved(self)