This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7268

hghave: add a check for pytype, Google's Python type checker
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:56 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG32ac4d0b4102: hghave: add a check for pytype, Google's Python type checker
Summary

I'm not unbiased, but I strongly prefer pytype to mypy: it does more
inference, so we don't need as many annontations. In theory we can use
both, but since I'm doing some tinkering with pytype I figured I'd
just try setting it up.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:56 PM
indygreg accepted this revision.Nov 7 2019, 3:07 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:07 AM

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (8 lines)

Diff 17685

tests/hghave.py

@check('black', 'the black formatter for python') @check('black', 'the black formatter for python')
def has_black(): def has_black():
blackcmd = 'black --version' blackcmd = 'black --version'
version_regex = b'black, version ([0-9a-b.]+)' version_regex = b'black, version ([0-9a-b.]+)'
version = matchoutput(blackcmd, version_regex) version = matchoutput(blackcmd, version_regex)
sv = distutils.version.StrictVersion sv = distutils.version.StrictVersion
return version and sv(_strpath(version.group(1))) >= sv('19.10b0') return version and sv(_strpath(version.group(1))) >= sv('19.10b0')
@check('pytype', 'the pytype type checker')
def has_pytype():
pytypecmd = 'pytype --version'
version = matchoutput(pytypecmd, b'[0-9a-b.]+')
sv = distutils.version.StrictVersion
return version and sv(_strpath(version.group(0))) >= sv('2019.10.17')