This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7270

linelog: suppress annoying pytype warning about an ignored metaclass
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:57 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGacc4047c2194: linelog: suppress annoying pytype warning about an ignored metaclass
Summary

This isn't actively hurting us right now, and it's not trivial to set
up this metaclass correctly on both Python 2 and Python 3 without
dragging in all of six, but we still get lots of typechecking
goodness with this error suppressed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/linelog.py (2 lines)

Diff 17686

mercurial/linelog.py

rev = attr.ib() rev = attr.ib()
lines = attr.ib() lines = attr.ib()
_eof = attr.ib() _eof = attr.ib()
def __iter__(self): def __iter__(self):
return iter(self.lines) return iter(self.lines)
class _llinstruction(object): class _llinstruction(object): # pytype: disable=ignored-metaclass
__metaclass__ = abc.ABCMeta __metaclass__ = abc.ABCMeta
@abc.abstractmethod @abc.abstractmethod
def __init__(self, op1, op2): def __init__(self, op1, op2):
pass pass
@abc.abstractmethod @abc.abstractmethod