This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7282

vfs: suppress some pytype errors around us using a private attribute
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGfc19f8ab8199: vfs: suppress some pytype errors around us using a private attribute
Summary

Looking at threading._MainThread seems like we're probably a little
unsupported, but since this code appears to work on both Python 2 and
3 I'm not going to sweat this for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/vfs.py (16 lines)

Diff 17697

mercurial/vfs.py

When this context manager is active, ``backgroundclose`` can be passed When this context manager is active, ``backgroundclose`` can be passed
to ``__call__``/``open`` to result in the file possibly being closed to ``__call__``/``open`` to result in the file possibly being closed
asynchronously, on a background thread. asynchronously, on a background thread.
""" """
# Sharing backgroundfilecloser between threads is complex and using # Sharing backgroundfilecloser between threads is complex and using
# multiple instances puts us at risk of running out of file descriptors # multiple instances puts us at risk of running out of file descriptors
# only allow to use backgroundfilecloser when in main thread. # only allow to use backgroundfilecloser when in main thread.
if not isinstance(threading.currentThread(), threading._MainThread): if not isinstance(
threading.currentThread(),
threading._MainThread, # pytype: disable=module-attr
):
yield yield
return return
vfs = getattr(self, 'vfs', self) vfs = getattr(self, 'vfs', self)
if getattr(vfs, '_backgroundfilecloser', None): if getattr(vfs, '_backgroundfilecloser', None):
raise error.Abort( raise error.Abort(
_(b'can only have 1 active background file closer') _(b'can only have 1 active background file closer')
) )
with backgroundfilecloser(ui, expectedcount=expectedcount) as bfc: with backgroundfilecloser(ui, expectedcount=expectedcount) as bfc:
try: try:
vfs._backgroundfilecloser = bfc vfs._backgroundfilecloser = (
bfc # pytype: disable=attribute-error
)
yield bfc yield bfc
finally: finally:
vfs._backgroundfilecloser = None vfs._backgroundfilecloser = (
None # pytype: disable=attribute-error
)
class vfs(abstractvfs): class vfs(abstractvfs):
'''Operate files relative to a base directory '''Operate files relative to a base directory
This class is used to hide the details of COW semantics and This class is used to hide the details of COW semantics and
remote file access from higher level code. remote file access from higher level code.
b'implementation error: mode %s is not' b'implementation error: mode %s is not'
b' valid for checkambig=True' b' valid for checkambig=True'
) )
% mode % mode
) )
fp = checkambigatclosing(fp) fp = checkambigatclosing(fp)
if backgroundclose and isinstance( if backgroundclose and isinstance(
threading.currentThread(), threading._MainThread threading.currentThread(),
threading._MainThread, # pytype: disable=module-attr
): ):
if not self._backgroundfilecloser: if not self._backgroundfilecloser:
raise error.Abort( raise error.Abort(
_( _(
b'backgroundclose can only be used when a ' b'backgroundclose can only be used when a '
b'backgroundclosing context manager is active' b'backgroundclosing context manager is active'
) )
) )