This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7276

posix: add a pytype suppression
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:57 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG147576a4e6a2: posix: add a pytype suppression
Summary

This one seems a little sketchier than the others, but this will clean
up when we're Python 3-only.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:57 PM
durin42 updated this revision to Diff 17667.Nov 6 2019, 6:22 PM
indygreg accepted this revision.Nov 7 2019, 3:14 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:14 AM
durin42 added a commit: rHG147576a4e6a2: posix: add a pytype suppression.Nov 7 2019, 3:32 AM
Closed by commit rHG147576a4e6a2: posix: add a pytype suppression (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/posix.py (5 lines)

Diff 17692

mercurial/posix.py

else: else:
# create a fixed file to link to; doesn't matter if it # create a fixed file to link to; doesn't matter if it
# already exists. # already exists.
target = b'checklink-target' target = b'checklink-target'
try: try:
fullpath = os.path.join(cachedir, target) fullpath = os.path.join(cachedir, target)
open(fullpath, b'w').close() open(fullpath, b'w').close()
except IOError as inst: except IOError as inst:
if inst[0] == errno.EACCES: if (
inst[0] # pytype: disable=unsupported-operands
== errno.EACCES
):
# If we can't write to cachedir, just pretend # If we can't write to cachedir, just pretend
# that the fs is readonly and by association # that the fs is readonly and by association
# that the fs won't support symlinks. This # that the fs won't support symlinks. This
# seems like the least dangerous way to avoid # seems like the least dangerous way to avoid
# data loss. # data loss.
return False return False
raise raise
try: try: