This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7316

revlog: return the nodemap as the nodecache
ClosedPublic

Authored by marmoute on Nov 8 2019, 4:29 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG90a0f631829e: revlog: return the nodemap as the nodecache
rHGc72464ccd3ca: revlog: return the nodemap as the nodecache
Summary

Ultimately, the nodecache is the nodemap. To stop having this disctinction, we
start using the nodemap where the nodecache was used.

This work is part of a refactoring to unify the revlog index and the nodemap.
This unification prepare the use of a persistent nodemap.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (2 lines)

Diff 17829

mercurial/revlog.py

return storageutil.iterrevs(len(self), start=start, stop=stop) return storageutil.iterrevs(len(self), start=start, stop=stop)
@util.propertycache @util.propertycache
def nodemap(self): def nodemap(self):
if self.index: if self.index:
# populate mapping down to the initial node # populate mapping down to the initial node
node0 = self.index[0][7] # get around changelog filtering node0 = self.index[0][7] # get around changelog filtering
self.rev(node0) self.rev(node0)
return self._nodecache return self.index.nodemap
def hasnode(self, node): def hasnode(self, node):
try: try:
self.rev(node) self.rev(node)
return True return True
except KeyError: except KeyError:
return False return False