The new index.rev(node) is to be preferred over using `node
index.nodemap[node]`.
This get us closer to be able to remove the nodemap attribute of the index.
Details
Details
- Reviewers
indygreg - Group Reviewers
hg-reviewers - Commits
- rHGbd87114ce341: index: add a `rev` method (API)
rHGb43a685edbc7: index: add a `rev` method (API)
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
The code is fine. But since I've already left a number of comments on this series, I thought I'd ask about raising a better exception than RevlogError. I thought we had dedicated exceptions for revision not existing?
Comment Actions
This is the exception currently raised by nodemap access and recognised by higher level code (that turn it into a better exception). Maybe this should change ? but this is out of scope from this series in my opinion.
Comment Actions
Perhaps it's best to bump the version number in this patch and the get_rev patch as well? I don't feel strongly, but I'll queue all the has_node patches to start with.