The new index.has_node(node) is to be preferred over:
`node in index.nodemap`.
This get us closer to be able to remove the nodemap attribute of the index.
indygreg |
hg-reviewers |
The new index.has_node(node) is to be preferred over:
`node in index.nodemap`.
This get us closer to be able to remove the nodemap attribute of the index.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
mercurial/cext/revlog.c | ||
---|---|---|
2071 | index_contains() can return -1 in many cases (including invalid input), which will cast to True. So this implementation needs improved. |
mercurial/cext/revlog.c | ||
---|---|---|
2071 | Good catch ! updating the patch. |
I think this needs to update the version number in mercurial/cext/parsers.c and in mercurial/policy.py. That will make hg fall back to pure code if it doesn't find the right version of the C code, making updating across this commit easier.