Page MenuHomePhabricator

index: use `index.has_node` in `tags.findglobaltags`
ClosedPublic

Authored by marmoute on Fri, Nov 8, 11:25 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Fri, Nov 8, 11:25 AM
indygreg accepted this revision.Fri, Nov 8, 5:12 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/tags.py
198

repo.changelog in loops is bad. If you could do a follow-up that aliases repo.changelog.index.has_node outside of the loop, it would be appreciated.

This revision is now accepted and ready to land.Fri, Nov 8, 5:12 PM
This revision was automatically updated to reflect the committed changes.