This is an archive of the discontinued Mercurial Phabricator instance.

mercurial/tags.py
198	`repo.changelog` in loops is bad. If you could do a follow-up that aliases `repo.changelog.index.has_node` outside of the loop, it would be appreciated.

This revision is now accepted and ready to land.Nov 8 2019, 5:12 PM

marmoute added a commit: rHG103b4430c1ae: index: use `index.has_node` in `tags.findglobaltags`.Nov 9 2019, 3:40 AM

Closed by commit rHG103b4430c1ae: index: use `index.has_node` in `tags.findglobaltags` (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

marmoute removed a child revision: D7343: index: use `index.get_rev` in `revset._mapbynodefunc`.Nov 9 2019, 8:14 AM

marmoute added a commit: rHG2c3afd083e45: index: use `index.has_node` in `tags.findglobaltags`.Nov 10 2019, 10:37 AM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/tags.py (4 lines)

Commit	Parents	Author	Summary	Date
227477fb5b1c	073706237325	Pierre-Yves David		Nov 8 2019, 5:44 AM

Status	Author	Revision
Closed	marmoute	D7362 revlog: deprecate direct `nodemap` access
Closed	marmoute	D7361 revlog: drop special hack in the `nodemap` property
Closed	marmoute	D7360 perf: make `perfrevlogindex` use the new `index.rev` api if available
Closed	marmoute	D7359 perf: make `perfphasesremote` use the new `index.has_node` api
Closed	marmoute	D7358 perf: make `perfnodemap` use the new `index.get_rev` api if available
Closed	marmoute	D7357 index: use `index.get_rev` in `remotefilelog`
Closed	marmoute	D7356 index: use `index.has_node` in `infinitypush`
Closed	marmoute	D7355 index: use `index.has_node` in `phabricator.getoldnodedrevmap`
Closed	marmoute	D7354 index: use `index.get_rev` in `histedit.processreplacement`
Closed	marmoute	D7353 index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`
Closed	marmoute	D7352 index: use `index.has_node` in `histedit.cleanupnode`
Closed	marmoute	D7351 index: use `index.has_node` in `histedit._finishhistedit
Closed	marmoute	D7350 index: use `index.get_rev` in `rebase._computeobsoletenotrebased`
Closed	marmoute	D7349 index: use `index.get_rev` in `rebase.successorrevs`
Closed	marmoute	D7331 index: use `index.has_node` in `phases.filterunknown`
Closed	marmoute	D7330 index: use `index.has_node` in `analyzeremotephases`
Closed	marmoute	D7329 index: use `index.has_node` in `repo._rollback`
Closed	marmoute	D7328 index: use `index.has_node` in `revlog.addgroup`
Closed	marmoute	D7339 index: use `index.has_node` in `bundlerepo.bundlerevlog`
Closed	marmoute	D7338 index: use `index.get_rev` in `unionrepo.unionrevlog`
Closed	marmoute	D7340 index: use `index.rev` in `bundlerepo.bundlerevlog`
Closed	marmoute	D7334 index: use `index.has_node` in `obsutil.foreground`
Closed	marmoute	D7333 index: use `index.has_node` in `obsutil.exclusivemarkers`
Closed	marmoute	D7348 index: use `index.has_node` in `exchangev2._pullchangesetdiscovery`
Closed	marmoute	D7347 index: use `index.get_rev` in `exchange._pullapplyphases`
Closed	marmoute	D7346 index: use `index.has_node` in `exchange._pulldiscoverychangegroup`
Closed	marmoute	D7345 index: use `index.rev` in `exchange.fallbackheads`
Closed	marmoute	D7344 index: use `index.has_node` in `bookmarks.bmstore`
Closed	marmoute	D7343 index: use `index.get_rev` in `revset._mapbynodefunc`
Closed	marmoute	D7342 index: use `index.has_node` in `tags.findglobaltags`
Closed	marmoute	D7341 index: use `index.get_rev` in `discovery._postprocessobsolete`
Closed	marmoute	D7337 index: use `index.get_rev` in `repoview.pinnedrevs`
Closed	marmoute	D7336 index: use `index.get_rev` in `obsolete._computephasedivergentset`
Closed	marmoute	D7335 index: use `index.get_rev` in `obsutil.getobsoleted`
Closed	marmoute	D7332 index: use `index.get_rev` in `phases.newheads`
Closed	marmoute	D7327 index: use `index.get_rev` in `localrepo.known`
Closed	marmoute	D7326 index: add a `get_rev` method (API)
Closed	marmoute	D7325 index: use `index.rev` in `revlog.rev`
Closed	marmoute	D7324 index: add a `rev` method (API)
Closed	marmoute	D7323 index: use `index.has_node` in `revlog.addrevision`
Closed	marmoute	D7322 index: add a `has_node` method (API)
Closed	marmoute	D7321 revlog: deal with nodemap deletion within the index
Closed	marmoute	D7320 revlog: clean up the node of all revision stripped in the C code
Closed	marmoute	D7319 revlog: move nodemap update within the index code
Closed	marmoute	D7318 revlog: deprecate the _nodecache attribute (API)
Closed	marmoute	D7317 revlog: access the nodemap through the index
Closed	marmoute	D7316 revlog: return the nodemap as the nodecache
Closed	marmoute	D7315 revlog: clarify which version use the older API in perf
Closed	marmoute	D7314 revlog: no longer return the nodemap after parsing
Closed	marmoute	D7313 revlog: move the nodemap into the index object (for pure)
Closed	marmoute	D7312 revlog: introduce an explicit NodeMap class for pure code
Closed	marmoute	D7311 utils: move the `dirs` definition in pathutil (API)

Diff 17765

mercurial/tags.py

	# XXX is this really 100% correct? are there oddball special			# XXX is this really 100% correct? are there oddball special
	# cases where a global tag should outrank a local tag but won't,			# cases where a global tag should outrank a local tag but won't,
	# because cachetags does not contain rank info?			# because cachetags does not contain rank info?
	alltags = {}			alltags = {}
	_updatetags(cachetags, alltags)			_updatetags(cachetags, alltags)
	return alltags			return alltags

	for head in reversed(heads): # oldest to newest			for head in reversed(heads): # oldest to newest
	assert (			assert repo.changelog.index.has_node(
	head in repo.changelog.nodemap			head
				indygregUnsubmitted Not Done `repo.changelog` in loops is bad. If you could do a follow-up that aliases `repo.changelog.index.has_node` outside of the loop, it would be appreciated. indygreg: `repo.changelog` in loops is bad. If you could do a follow-up that aliases `repo.changelog.
	), b"tag cache returned bogus head %s" % short(head)			), b"tag cache returned bogus head %s" % short(head)
	fnodes = _filterfnodes(tagfnode, reversed(heads))			fnodes = _filterfnodes(tagfnode, reversed(heads))
	alltags = _tagsfromfnodes(ui, repo, fnodes)			alltags = _tagsfromfnodes(ui, repo, fnodes)

	# and update the cache (if necessary)			# and update the cache (if necessary)
	if shouldwrite:			if shouldwrite:
	_writetagcache(ui, repo, valid, alltags)			_writetagcache(ui, repo, valid, alltags)
	return alltags			return alltags

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17765		Nov 8 2019, 11:25 AM	★	★
Diff 2	17874	rHG103b4430c1ae2669a4baf74476b667f528535bfc	Nov 8 2019, 5:44 AM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

index: use `index.has_node` in `tags.findglobaltags`ClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17765

mercurial/tags.py

index: use `index.has_node` in `tags.findglobaltags`
ClosedPublic

Revision Contents
Changeset List