This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7318

revlog: deprecate the _nodecache attribute (API)
ClosedPublic

Authored by marmoute on Nov 8 2019, 4:29 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6e3e3e5446ba: revlog: deprecate the _nodecache attribute (API)
rHGda4afbbbe44a: revlog: deprecate the _nodecache attribute (API)
Summary

This attribute have been the same object for a long time. Code should directly
access the nodemap in case of need. (Or the final API when this will be done).

This work is part of a refactoring to unify the revlog index and the nodemap.
This unification prepare the use of a persistent nodemap.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (9 lines)

Diff 17734

mercurial/revlog.py

# How much data to read and cache into the raw revlog data cache. # How much data to read and cache into the raw revlog data cache.
self._chunkcachesize = 65536 self._chunkcachesize = 65536
self._maxchainlen = None self._maxchainlen = None
self._deltabothparents = True self._deltabothparents = True
self.index = None self.index = None
# Mapping of partial identifiers to full nodes. # Mapping of partial identifiers to full nodes.
self._pcache = {} self._pcache = {}
# Mapping of revision integer to full node. # Mapping of revision integer to full node.
self._nodecache = None
self._nodepos = None self._nodepos = None
self._compengine = b'zlib' self._compengine = b'zlib'
self._compengineopts = {} self._compengineopts = {}
self._maxdeltachainspan = -1 self._maxdeltachainspan = -1
self._withsparseread = False self._withsparseread = False
self._sparserevlog = False self._sparserevlog = False
self._srdensitythreshold = 0.50 self._srdensitythreshold = 0.50
self._srmingapsize = 262144 self._srmingapsize = 262144
self._io = revlogoldio() self._io = revlogoldio()
try: try:
d = self._io.parseindex(indexdata, self._inline) d = self._io.parseindex(indexdata, self._inline)
except (ValueError, IndexError): except (ValueError, IndexError):
raise error.RevlogError( raise error.RevlogError(
_(b"index %s is corrupted") % self.indexfile _(b"index %s is corrupted") % self.indexfile
) )
self.index, self._chunkcache = d self.index, self._chunkcache = d
self.nodemap = self._nodecache = self.index.nodemap self.nodemap = self.index.nodemap
if not self._chunkcache: if not self._chunkcache:
self._chunkclear() self._chunkclear()
# revnum -> (chain-length, sum-delta-length) # revnum -> (chain-length, sum-delta-length)
self._chaininfocache = {} self._chaininfocache = {}
# revlog header -> revlog compressor # revlog header -> revlog compressor
self._decompressors = {} self._decompressors = {}
@util.propertycache @util.propertycache
@util.propertycache @util.propertycache
def nodemap(self): def nodemap(self):
if self.index: if self.index:
# populate mapping down to the initial node # populate mapping down to the initial node
node0 = self.index[0][7] # get around changelog filtering node0 = self.index[0][7] # get around changelog filtering
self.rev(node0) self.rev(node0)
return self.index.nodemap return self.index.nodemap
@property
def _nodecache(self):
msg = "revlog._nodecache is deprecated, use revlog.index.nodemap"
util.nouideprecwarn(msg, b'5.3', stacklevel=2)
return self.index.nodemap
def hasnode(self, node): def hasnode(self, node):
try: try:
self.rev(node) self.rev(node)
return True return True
except KeyError: except KeyError:
return False return False
def candelta(self, baserev, rev): def candelta(self, baserev, rev):