( )⚙ D7344 index: use `index.has_node` in `bookmarks.bmstore`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7344

index: use `index.has_node` in `bookmarks.bmstore`
ClosedPublic

Authored by marmoute on Nov 8 2019, 11:25 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG886ec3962c66: index: use `index.has_node` in `bookmarks.bmstore`
rHGa35bbeef9d88: index: use `index.has_node` in `bookmarks.bmstore`

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/bookmarks.py (4 lines)

Diff 17875

mercurial/bookmarks.py

""" """
def __init__(self, repo): def __init__(self, repo):
self._repo = repo self._repo = repo
self._refmap = refmap = {} # refspec: node self._refmap = refmap = {} # refspec: node
self._nodemap = nodemap = {} # node: sorted([refspec, ...]) self._nodemap = nodemap = {} # node: sorted([refspec, ...])
self._clean = True self._clean = True
self._aclean = True self._aclean = True
nm = repo.changelog.nodemap has_node = repo.changelog.index.has_node
tonode = bin # force local lookup tonode = bin # force local lookup
try: try:
with _getbkfile(repo) as bkfile: with _getbkfile(repo) as bkfile:
for line in bkfile: for line in bkfile:
line = line.strip() line = line.strip()
if not line: if not line:
continue continue
try: try:
sha, refspec = line.split(b' ', 1) sha, refspec = line.split(b' ', 1)
node = tonode(sha) node = tonode(sha)
if node in nm: if has_node(node):
refspec = encoding.tolocal(refspec) refspec = encoding.tolocal(refspec)
refmap[refspec] = node refmap[refspec] = node
nrefs = nodemap.get(node) nrefs = nodemap.get(node)
if nrefs is None: if nrefs is None:
nodemap[node] = [refspec] nodemap[node] = [refspec]
else: else:
nrefs.append(refspec) nrefs.append(refspec)
if nrefs[-2] > refspec: if nrefs[-2] > refspec: