( )⚙ D7456 scmutil: add assertions to help pytype

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7456

scmutil: add assertions to help pytype
ClosedPublic

Authored by mharbison72 on Nov 19 2019, 5:46 PM.

Details

Reviewers
indygreg
dlax
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5b90a050082b: scmutil: add assertions to help pytype

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Nov 19 2019, 5:46 PM
indygreg accepted this revision.Nov 19 2019, 9:41 PM
This revision is now accepted and ready to land.Nov 19 2019, 9:41 PM
dlax accepted this revision.Nov 20 2019, 2:59 AM
pulkit accepted this revision.Nov 21 2019, 7:29 AM
mharbison72 added a commit: rHG5b90a050082b: scmutil: add assertions to help pytype.Nov 21 2019, 8:34 AM
Closed by commit rHG5b90a050082b: scmutil: add assertions to help pytype (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 18257

mercurial/scmutil.py

# unfiltered object and restore the filtering when retrieving the # unfiltered object and restore the filtering when retrieving the
# repository through the weakref. # repository through the weakref.
filtername = repo.filtername filtername = repo.filtername
reporef = weakref.ref(repo.unfiltered()) reporef = weakref.ref(repo.unfiltered())
def wrapped(tr): def wrapped(tr):
repo = reporef() repo = reporef()
if filtername: if filtername:
assert repo is not None # help pytype
repo = repo.filtered(filtername) repo = repo.filtered(filtername)
func(repo, tr) func(repo, tr)
newcat = b'%02i-txnreport' % len(categories) newcat = b'%02i-txnreport' % len(categories)
otr.addpostclose(newcat, wrapped) otr.addpostclose(newcat, wrapped)
categories.append(newcat) categories.append(newcat)
return wrapped return wrapped
@reportsummary @reportsummary
def reportchangegroup(repo, tr): def reportchangegroup(repo, tr):
cgchangesets = tr.changes.get(b'changegroup-count-changesets', 0) cgchangesets = tr.changes.get(b'changegroup-count-changesets', 0)
cgrevisions = tr.changes.get(b'changegroup-count-revisions', 0) cgrevisions = tr.changes.get(b'changegroup-count-revisions', 0)
cgfiles = tr.changes.get(b'changegroup-count-files', 0) cgfiles = tr.changes.get(b'changegroup-count-files', 0)
cgheads = tr.changes.get(b'changegroup-count-heads', 0) cgheads = tr.changes.get(b'changegroup-count-heads', 0)
if cgchangesets or cgrevisions or cgfiles: if cgchangesets or cgrevisions or cgfiles:
htext = b"" htext = b""
if cgheads: if cgheads:
htext = _(b" (%+d heads)") % cgheads htext = _(b" (%+d heads)") % cgheads
msg = _(b"added %d changesets with %d changes to %d files%s\n") msg = _(b"added %d changesets with %d changes to %d files%s\n")
assert repo is not None # help pytype
repo.ui.status(msg % (cgchangesets, cgrevisions, cgfiles, htext)) repo.ui.status(msg % (cgchangesets, cgrevisions, cgfiles, htext))
if txmatch(_reportobsoletedsource): if txmatch(_reportobsoletedsource):
@reportsummary @reportsummary
def reportobsoleted(repo, tr): def reportobsoleted(repo, tr):
obsoleted = obsutil.getobsoleted(repo, tr) obsoleted = obsutil.getobsoleted(repo, tr)
newmarkers = len(tr.changes.get(b'obsmarkers', ())) newmarkers = len(tr.changes.get(b'obsmarkers', ()))