( )⚙ D7581 rust-configparser: regenerate parser.rs

This is an archive of the discontinued Mercurial Phabricator instance.

rust-configparser: regenerate parser.rs
AbandonedPublic

Authored by indygreg on Dec 7 2019, 5:56 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

I couldn't get generate_parser.py to work without modification
because my version of cargo-expand didn't accept a --release
argument. I assume --release isn't supported in the newest version
of this tool.

Once I did get it to run, the auto-generated file wasn't formatted
at all and was literally just a wall of unreadable tokens. It appears
we were disabling rustfmt as part of generating the file. So I
removed that and got a working generation of parser.rs!

The changes to parser.rs reflect the new auto-generated content.

I also snuck in the addition of a rustfmt::skip attribute. This
is needed to avoid rustfmt complaining about the content of this
file.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Dec 7 2019, 5:56 PM
indygreg abandoned this revision.Dec 7 2019, 10:04 PM

The autogenerated parser.rs and its Python script to generate it have been removed in the latest version of this series.

rust/hg-core/src/configparser/generate_parser.py