hg-core: run rustfmt on configparser
AcceptedPublic
Actions

Authored by indygreg on Dec 7 2019, 5:57 PM.

Details

Reviewers

Alphare
durin42

Group Reviewers

hg-reviewers

Summary

The vendored code doesn't follow modern rustfmt's conventions.
This commit runs rustfmt so it does.

skip-blame rustfmt

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

indygreg created this revision.Dec 7 2019, 5:57 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptDec 7 2019, 5:57 PM

Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42. · View Herald Transcript

indygreg added a child revision: D7577: hg-core: implement Mercurial's config file discovery logic.Dec 7 2019, 5:57 PM

We actually ran rustfmt, but it's an older version (rustfmt 1.3.0-stable (d334502 2019-06-09)) and I verified the code still formats under that particular version of rustfmt with empty rustfmt.toml. In other words, rustfmt itself seems to change over time.

indygreg edited parent revisions, added: D7575: hg-core: vendor Facebook's configparser crate; removed: D7581: rust-configparser: regenerate parser.rs.Dec 7 2019, 10:03 PM

indygreg retitled this revision from rust-configparser: run rustfmt to hg-core: run rustfmt on configparser.

indygreg edited the summary of this revision. (Show Details)

indygreg added a child revision: D7576: hg-core: add configparser to library.

indygreg removed a child revision: D7577: hg-core: implement Mercurial's config file discovery logic.

indygreg updated this revision to Diff 18546.

Alphare accepted this revision.Dec 9 2019, 8:16 AM

durin42 accepted this revision.Dec 11 2019, 12:45 PM

This revision is now accepted and ready to land.Dec 11 2019, 12:45 PM

Revision Contents
Changeset List

			Path	Packages
M			rust/hg-core/src/configparser/c_api.rs (21 lines)
M			rust/hg-core/src/configparser/config.rs (357 lines)
M			rust/hg-core/src/configparser/hg.rs (233 lines)
M			rust/hg-core/src/configparser/lib.rs (4 lines)

Commit	Parents	Author	Summary	Date
e8ec811bf019	1eda551870ad	Gregory Szorc		Dec 7 2019, 10:01 PM

Status	Author	Revision
Abandoned	indygreg	D7581 rust-configparser: regenerate parser.rs
Needs Review	indygreg	D7577 hg-core: implement Mercurial's config file discovery logic
Needs Review	indygreg	D7576 hg-core: add configparser to library
Accepted	indygreg	D7582 hg-core: run rustfmt on configparser
Needs Review	indygreg	D7575 hg-core: vendor Facebook's configparser crate
Needs Revision	indygreg	D7574 hg-core: add utils::path to project
Closed	indygreg	D7580 hg-core: rustfmt path.rs
Closed	indygreg	D7573 hg-core: vendor Facebook's path utils module