Page MenuHomePhabricator

hg-core: implement Mercurial's config file discovery logic
Needs RevisionPublic

Authored by indygreg on Dec 7 2019, 3:17 PM.

Details

Reviewers
kevincox
Alphare
baymax
Group Reviewers
hg-reviewers
Summary

The imported Facebook code for locating Mercurial config files
differed from what Mercurial itself does. This commit modifies the
logic to match what Mercurial currently does.

As part of this, we added some crate dependencies. We could probably
avoid these dependencies if we want. But these crates are quite popular
and useful and I imagine we'll end up using them eventually.

We should probably add some test coverage of this code...

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Dec 7 2019, 3:17 PM
indygreg retitled this revision from rust-configparser: implement Mercurial's config file discovery logic to hg-core: implement Mercurial's config file discovery logic.
kevincox accepted this revision.Dec 9 2019, 7:23 AM
kevincox added inline comments.
rust/hg-core/src/configparser/config.rs
145

I believe this can just be .flatten().

Alphare accepted this revision.Dec 9 2019, 8:08 AM
baymax requested changes to this revision.Apr 22 2020, 11:53 AM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Apr 22 2020, 11:53 AM