This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7695

patch: fix header.__repr__() to not have `b''` prefixes in file names
ClosedPublic

Authored by mharbison72 on Dec 17 2019, 11:34 PM.

Details

Reviewers
dlax
pulkit
Group Reviewers
hg-reviewers
Commits
rHG0671f0a19d93: patch: fix header.__repr__() to not have `b''` prefixes in file names
Summary

Spotted by Denis Laxalde.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 17 2019, 11:34 PM
dlax accepted this revision.Dec 18 2019, 3:06 AM
pulkit accepted this revision.Dec 19 2019, 12:13 PM
This revision is now accepted and ready to land.Dec 19 2019, 12:13 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/patch.py (4 lines)

Diff 18885

mercurial/patch.py

return [fromfile, tofile] return [fromfile, tofile]
else: else:
return self.diff_re.match(self.header[0]).groups() return self.diff_re.match(self.header[0]).groups()
def filename(self): def filename(self):
return self.files()[-1] return self.files()[-1]
def __repr__(self): def __repr__(self):
return '<header %s>' % (' '.join(map(repr, self.files()))) return '<header %s>' % (
' '.join(pycompat.rapply(pycompat.fsdecode, self.files()))
)
def isnewfile(self): def isnewfile(self):
return any(self.newfile_re.match(h) for h in self.header) return any(self.newfile_re.match(h) for h in self.header)
def special(self): def special(self):
# Special files are shown only at the header level and not at the hunk # Special files are shown only at the header level and not at the hunk
# level for example a file that has been deleted is a special file. # level for example a file that has been deleted is a special file.
# The user cannot change the content of the operation, in the case of # The user cannot change the content of the operation, in the case of