This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7718

rust-directory: simplify bidirectional sampling
Needs RevisionPublic

Authored by gracinet on Dec 24 2019, 8:50 AM.

Details

Reviewers
Alphare
baymax
Group Reviewers
hg-reviewers
Summary

Thanks to the typestate pattern, we don't have a
complicated management of borrows to perform in
that method with the early return condition and
the comment was just obsolete.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

gracinet created this revision.Dec 24 2019, 8:50 AM
Alphare accepted this revision.Jan 3 2020, 4:47 AM
baymax requested changes to this revision.Apr 22 2020, 11:53 AM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Apr 22 2020, 11:53 AM

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/discovery.rs (9 lines)

Diff 18926

rust/hg-core/src/discovery.rs

/// No effort is being made to complete or limit the sample to `size` /// No effort is being made to complete or limit the sample to `size`
/// but this method returns another interesting size that it derives /// but this method returns another interesting size that it derives
/// from its knowledge of the structure of the various sets, leaving /// from its knowledge of the structure of the various sets, leaving
/// to the caller the decision to use it or not. /// to the caller the decision to use it or not.
fn bidirectional_sample( fn bidirectional_sample(
&mut self, &mut self,
size: usize, size: usize,
) -> Result<(HashSet<Revision>, usize), GraphError> { ) -> Result<(HashSet<Revision>, usize), GraphError> {
{
// we don't want to compute children_cache before this
// but doing it after extracting self.undecided takes a mutable
// ref to self while a shareable one is still active.
if self.undecided.len() <= size { if self.undecided.len() <= size {
return Ok((self.undecided.clone(), size)); return Ok((self.undecided.clone(), size));
} }
}
self.ensure_children_cache()?; self.ensure_children_cache()?;
let revs = &self.undecided; let revs = &self.undecided;
let mut sample: HashSet<Revision> = revs.clone(); let mut sample: HashSet<Revision> = revs.clone();
// it's possible that leveraging the children cache would be more // it's possible that leveraging the children cache would be more
// efficient here // efficient here
dagops::retain_heads(&self.graph, &mut sample)?; dagops::retain_heads(&self.graph, &mut sample)?;