This is an archive of the discontinued Mercurial Phabricator instance.

rust-discovery: children cache as typestate transition
Needs RevisionPublic

Authored by gracinet on Dec 24 2019, 8:50 AM.

Details

Reviewers
Alphare
baymax
Group Reviewers
hg-reviewers
Summary

As of 8c9a6adec67a, we were actually using
the children cache right away in add_missing_revisions,
the method that also triggers the undecided set computation
(see that changeset description for the corresponding
performance discussion).

This means we don't need a third typestate for the children
cache: WithUndecided can always have it.

It is clear that compute_children_cache does not have
to be tied to the WithUndecided struct anymore. We may
move it to hg::dagops in a later move.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

gracinet created this revision.Dec 24 2019, 8:50 AM
Alphare accepted this revision.Jan 3 2020, 4:52 AM
baymax requested changes to this revision.Apr 22 2020, 11:52 AM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Apr 22 2020, 11:52 AM