This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7736

ancestor: drop an unused local variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5ce6daa67658: ancestor: drop an unused local variable assignment
Summary

Caught by PyCharm.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:16 PM
mharbison72 added a commit: rHG5ce6daa67658: ancestor: drop an unused local variable assignment.Dec 27 2019, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG5ce6daa67658: ancestor: drop an unused local variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ancestor.py (2 lines)

Diff 18967

mercurial/ancestor.py

iteration and membership. iteration and membership.
cl should be a changelog and revs should be an iterable. inclusive is cl should be a changelog and revs should be an iterable. inclusive is
a boolean that indicates whether revs should be included. Revs lower a boolean that indicates whether revs should be included. Revs lower
than stoprev will not be generated. than stoprev will not be generated.
Result does not include the null revision.""" Result does not include the null revision."""
self._parentrevs = pfunc self._parentrevs = pfunc
self._initrevs = revs = [r for r in revs if r >= stoprev] self._initrevs = [r for r in revs if r >= stoprev]
self._stoprev = stoprev self._stoprev = stoprev
self._inclusive = inclusive self._inclusive = inclusive
self._containsseen = set() self._containsseen = set()
self._containsiter = _lazyancestorsiter( self._containsiter = _lazyancestorsiter(
self._parentrevs, self._initrevs, self._stoprev, self._inclusive self._parentrevs, self._initrevs, self._stoprev, self._inclusive
) )