This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7748

hgweb: drop an unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:17 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3e4294aa7944: hgweb: drop an unused variable assignment
Summary

Caught by PyCharm.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:17 PM
mharbison72 added a commit: rHG3e4294aa7944: hgweb: drop an unused variable assignment.Dec 27 2019, 5:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3e4294aa7944: hgweb: drop an unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webcommands.py (1 line)

Diff 18964

mercurial/hgweb/webcommands.py

reponame = re.sub(br"\W+", b"-", os.path.basename(web.reponame)) reponame = re.sub(br"\W+", b"-", os.path.basename(web.reponame))
cnode = web.repo.lookup(key) cnode = web.repo.lookup(key)
arch_version = key arch_version = key
if cnode == key or key == b'tip': if cnode == key or key == b'tip':
arch_version = short(cnode) arch_version = short(cnode)
name = b"%s-%s" % (reponame, arch_version) name = b"%s-%s" % (reponame, arch_version)
ctx = webutil.changectx(web.repo, web.req) ctx = webutil.changectx(web.repo, web.req)
pats = []
match = scmutil.match(ctx, []) match = scmutil.match(ctx, [])
file = web.req.qsparams.get(b'file') file = web.req.qsparams.get(b'file')
if file: if file:
pats = [b'path:' + file] pats = [b'path:' + file]
match = scmutil.match(ctx, pats, default=b'path') match = scmutil.match(ctx, pats, default=b'path')
if pats: if pats:
files = [f for f in ctx.manifest().keys() if match(f)] files = [f for f in ctx.manifest().keys() if match(f)]
if not files: if not files: