This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7812

examples: specify rustfmt nightly using a $() construct
ClosedPublic

Authored by durin42 on Jan 8 2020, 2:38 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5e0505d36aee: examples: specify rustfmt nightly using a $() construct
rHG229a1e17df58: examples: specify rustfmt nightly using a $() construct
rHG6e13b31f83b5: examples: specify rustfmt nightly using a $() construct
Summary

This is ugly, but it's how we have to configure rustfmt for now as we
require nightly rustfmt.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

durin42 created this revision.Jan 8 2020, 2:38 PM
gracinet added a subscriber: gracinet.Jan 8 2020, 3:06 PM

thanks for the tip. Fun fact: rustup which doesn't have a --toolchain option on my system, so perhaps it needs to be itself upgraded, (and that might explain a few things.
I've been using rustmt nightly since forever, but maybe I'm stuck on an old version of it.

quark added a subscriber: quark.EditedJan 9 2020, 1:52 AM

You can use rustfmt +nightly if it's installed by rustup. It also runs on Windows.

gracinet added a comment.Jan 10 2020, 8:46 AM

Ok, so yes I had an old version of rustfmt-nightly, dating back to the days it wasn't managed by rustup (crate rustfmt-nightly).
Thanks for the heads up, guys.

Now I'm pretty sure that cargo +nightly fmt just calls rustup +nightly fmt.

pulkit added a subscriber: pulkit.Jan 13 2020, 11:17 AM

@gracinet Does this looks good to you?

gracinet added a comment.Jan 13 2020, 2:57 PM

@pulkit yes, after toolchain reinstall, this rustup which works for me

pulkit accepted this revision.Jan 14 2020, 9:52 AM
This revision is now accepted and ready to land.Jan 14 2020, 9:52 AM
durin42 added a commit: rHG6e13b31f83b5: examples: specify rustfmt nightly using a $() construct.Jan 14 2020, 11:13 AM
Closed by commit rHG6e13b31f83b5: examples: specify rustfmt nightly using a $() construct (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.
martinvonz added a subscriber: martinvonz.Jan 16 2020, 11:38 AM

I was just going to note that it seems like this would not work on Windows, but then I saw Jun's comment which seems to suggest the same. I'll send a patch to switch to Jun's proposal.

Revision Contents
Changeset List

PathPackages
Mcontrib/examples/fix.hgrc (2 lines)

Diff 19087

contrib/examples/fix.hgrc

[fix] [fix]
clang-format:command = clang-format --style file clang-format:command = clang-format --style file
clang-format:pattern = set:(**.c or **.cc or **.h) and not "include:contrib/clang-format-ignorelist" clang-format:pattern = set:(**.c or **.cc or **.h) and not "include:contrib/clang-format-ignorelist"
rustfmt:command = rustfmt rustfmt:command = $(rustup which --toolchain nightly rustfmt)
rustfmt:pattern = set:**.rs rustfmt:pattern = set:**.rs
black:command = black --config=black.toml - black:command = black --config=black.toml -
black:pattern = set:**.py - mercurial/thirdparty/** - "contrib/python-zstandard/**" black:pattern = set:**.py - mercurial/thirdparty/** - "contrib/python-zstandard/**"
# Mercurial doesn't have any Go code, but if we did this is how we # Mercurial doesn't have any Go code, but if we did this is how we
# would configure `hg fix` for Go: # would configure `hg fix` for Go:
go:command = gofmt go:command = gofmt
go:pattern = set:**.go go:pattern = set:**.go