This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8163

nodemap: use data from the index in debugnodemap --dump-new
ClosedPublic

Authored by Alphare on Feb 26 2020, 12:37 PM.

Download Raw Diff

Tags

None

Subscribers

marmoute, mercurial-devel

Details

Reviewers

None

Group Reviewers

Commits

rHGfebe88a6f7f7: nodemap: use data from the index in debugnodemap --dump-new

Summary

It is better to run the actual code when generating a new nodemap cache from
scratch. So we do.

Diff Detail

Repository

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

Alphare created this revision.Feb 26 2020, 12:37 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFeb 26 2020, 12:37 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

Alphare added a child revision: D8164: rust-nodemap: automatically use the rust index for persistent nodemap.Feb 26 2020, 12:37 PM

marmoute added a child revision: D8180: nodemap: check that a simple lookup works fine.Feb 28 2020, 1:54 PM

marmoute removed a child revision: D8164: rust-nodemap: automatically use the rust index for persistent nodemap.

simple rebase

eventless rebase past D8255

pulkit added a child revision: D8164: rust-nodemap: automatically use the rust index for persistent nodemap.Mar 9 2020, 5:28 AM

pulkit edited parent revisions, added: D8161: rust-nodemap: also clear Rust data in `clearcaches`; removed: D8162: hghave: add a `rust` keyword to detect the use of compiled rust code.

Alphare updated this revision to Diff 20661.Mar 10 2020, 6:52 AM

marmoute added a commit: rHGfebe88a6f7f7: nodemap: use data from the index in debugnodemap --dump-new.Mar 11 2020, 11:43 AM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGfebe88a6f7f7: nodemap: use data from the index in debugnodemap --dump-new (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/debugcommands.py (5 lines)

Diff 20436

mercurial/debugcommands.py

	],			],
	)			)
	def debugnodemap(ui, repo, **opts):			def debugnodemap(ui, repo, **opts):
	"""write and inspect on disk nodemap			"""write and inspect on disk nodemap
	"""			"""
	if opts['dump_new']:			if opts['dump_new']:
	unfi = repo.unfiltered()			unfi = repo.unfiltered()
	cl = unfi.changelog			cl = unfi.changelog
				if util.safehasattr(cl.index, "nodemap_data_all"):
				data = cl.index.nodemap_data_all()
				else:
	data = nodemap.persistent_data(cl.index)			data = nodemap.persistent_data(cl.index)
	ui.write(data)			ui.write(data)
	elif opts['dump_disk']:			elif opts['dump_disk']:
	unfi = repo.unfiltered()			unfi = repo.unfiltered()
	cl = unfi.changelog			cl = unfi.changelog
	nm_data = nodemap.persisted_data(cl)			nm_data = nodemap.persisted_data(cl)
	if nm_data is not None:			if nm_data is not None:
	docket, data = nm_data			docket, data = nm_data
	ui.write(data[:])			ui.write(data[:])