( )⚙ D8348 tests: force newlines to LF in inline Python script

This is an archive of the discontinued Mercurial Phabricator instance.

tests: force newlines to LF in inline Python script
Needs RevisionPublic

Authored by indygreg on Mar 29 2020, 9:30 PM.

Details

Reviewers
marmoute
baymax
Group Reviewers
hg-reviewers
Summary

Like we've done in what seems like an infinite stream of random
scripts, we need to set sys.stdout to normalize to LF on
Python 3 on Windows or else CRLF can creep in.

With this change, test-fix.t now passes on Python 3 on Windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 29 2020, 9:30 PM
marmoute accepted this revision.Apr 17 2020, 2:30 PM
marmoute added a subscriber: marmoute.

looks legit.

marmoute resigned from this revision.

actually @mharbison72 comment on D8345 make me reconsider. Please allign the status of this with the status of D8345.

marmoute accepted this revision.Apr 17 2020, 4:01 PM
baymax requested changes to this revision.Jul 31 2020, 1:56 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jul 31 2020, 1:56 PM