This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8408

nodemap: skip persistent nodemap warming for revlog not using it
ClosedPublic

Authored by marmoute on Apr 14 2020, 11:48 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHGb4537125eb3c: nodemap: skip persistent nodemap warming for revlog not using it
Summary

Before this patch, the usual checking (especially, inline-ess) were not
performed when warming the cache through hg debugupdatecache.

This is now fixed.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (5 lines)

Diff 21056

mercurial/revlogutils/nodemap.py

def update_persistent_nodemap(revlog): def update_persistent_nodemap(revlog):
"""update the persistent nodemap right now """update the persistent nodemap right now
To be used for updating the nodemap on disk outside of a normal transaction To be used for updating the nodemap on disk outside of a normal transaction
setup (eg, `debugupdatecache`). setup (eg, `debugupdatecache`).
""" """
if revlog._inline:
return # inlined revlog are too small for this to be relevant
if revlog.nodemap_file is None:
return # we do not use persistent_nodemap on this revlog
notr = _NoTransaction() notr = _NoTransaction()
_persist_nodemap(notr, revlog) _persist_nodemap(notr, revlog)
for k in sorted(notr._postclose): for k in sorted(notr._postclose):
notr._postclose[k](None) notr._postclose[k](None)
def _persist_nodemap(tr, revlog, pending=False): def _persist_nodemap(tr, revlog, pending=False):
"""Write nodemap data on disk for a given revlog """Write nodemap data on disk for a given revlog