( )⚙ D8416 nodemap: move on disk file to version 1

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8416

nodemap: move on disk file to version 1
ClosedPublic

Authored by marmoute on Apr 14 2020, 11:48 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG261e71752d1f: nodemap: move on disk file to version 1
Summary

The current format contains the information we need, lets freeze it before the
release.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2020, 11:48 AM
marmoute updated this revision to Diff 21094.Apr 15 2020, 7:59 AM
durin42 added a subscriber: durin42.Apr 16 2020, 12:07 PM
durin42 added inline comments.
mercurial/revlogutils/nodemap.py
270

I feel like this comment is outdated? please send a follow-up (even if it's for stable after the freeze) on this.

marmoute updated this revision to Diff 21147.Apr 16 2020, 1:14 PM
marmoute added a comment.Apr 16 2020, 1:15 PM

good catch, I updated the diff.

Alphare accepted this revision.May 7 2020, 9:03 AM
marmoute added a commit: rHG261e71752d1f: nodemap: move on disk file to version 1.May 7 2020, 11:34 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG261e71752d1f: nodemap: move on disk file to version 1 (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (2 lines)

Diff 21064

mercurial/revlogutils/nodemap.py

# new one beind used by an in progress transaction). To accomodate this, the # new one beind used by an in progress transaction). To accomodate this, the
# filename hosting the raw data has a variable parts. The exact filename is # filename hosting the raw data has a variable parts. The exact filename is
# specified inside the "docket" file. # specified inside the "docket" file.
# #
# The docket file contains information to find, qualify and validate the raw # The docket file contains information to find, qualify and validate the raw
# data. Its content is currently very light, but it will expand as the on disk # data. Its content is currently very light, but it will expand as the on disk
# nodemap gains the necessary features to be used in production. # nodemap gains the necessary features to be used in production.
# version 0 is experimental, no BC garantee, do no use outside of tests. # version 0 is experimental, no BC garantee, do no use outside of tests.
durin42Unsubmitted
Not Done

I feel like this comment is outdated? please send a follow-up (even if it's for stable after the freeze) on this.

durin42: I feel like this comment is outdated? please send a follow-up (even if it's for stable after…
ONDISK_VERSION = 0 ONDISK_VERSION = 1
S_VERSION = struct.Struct(">B") S_VERSION = struct.Struct(">B")
S_HEADER = struct.Struct(">BQQQQ") S_HEADER = struct.Struct(">BQQQQ")
ID_SIZE = 8 ID_SIZE = 8
def _make_uid(): def _make_uid():
"""return a new unique identifier. """return a new unique identifier.