( )⚙ D8419 nodemap: move the main switch to the `format` section

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8419

nodemap: move the main switch to the `format` section
ClosedPublic

Authored by marmoute on Apr 14 2020, 11:49 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGd688a8d537b9: nodemap: move the main switch to the `format` section
Summary

The config to enable persistent nodemap is now format.use-persistent-nodemap.
However the option remain marked as experimental because it only improve
performance for people using the rust extensions.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2020, 11:49 AM
marmoute updated this revision to Diff 21230.Apr 27 2020, 1:12 PM
Alphare accepted this revision.May 7 2020, 9:13 AM
marmoute added a commit: rHGd688a8d537b9: nodemap: move the main switch to the `format` section.May 7 2020, 11:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd688a8d537b9: nodemap: move the main switch to the `format` section (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21067

mercurial/configitems.py

) )
coreconfigitem( coreconfigitem(
b'experimental', b'revisions.disambiguatewithin', default=None, b'experimental', b'revisions.disambiguatewithin', default=None,
) )
coreconfigitem( coreconfigitem(
b'experimental', b'rust.index', default=False, b'experimental', b'rust.index', default=False,
) )
coreconfigitem( coreconfigitem(
b'experimental', b'exp-persistent-nodemap', default=False,
)
coreconfigitem(
b'experimental', b'exp-persistent-nodemap.mmap', default=True, b'experimental', b'exp-persistent-nodemap.mmap', default=True,
) )
coreconfigitem( coreconfigitem(
b'experimental', b'exp-persistent-nodemap.mode', default=b'compat', b'experimental', b'exp-persistent-nodemap.mode', default=b'compat',
) )
coreconfigitem( coreconfigitem(
b'experimental', b'server.filesdata.recommended-batch-size', default=50000, b'experimental', b'server.filesdata.recommended-batch-size', default=50000,
) )
) )
coreconfigitem( coreconfigitem(
b'format', b'usegeneraldelta', default=True, b'format', b'usegeneraldelta', default=True,
) )
coreconfigitem( coreconfigitem(
b'format', b'usestore', default=True, b'format', b'usestore', default=True,
) )
coreconfigitem( coreconfigitem(
b'format', b'use-persistent-nodemap', default=False, experimental=True
)
coreconfigitem(
b'format', b'format',
b'exp-use-copies-side-data-changeset', b'exp-use-copies-side-data-changeset',
default=False, default=False,
experimental=True, experimental=True,
) )
coreconfigitem( coreconfigitem(
b'format', b'exp-use-side-data', default=False, experimental=True, b'format', b'exp-use-side-data', default=False, experimental=True,
) )

mercurial/localrepo.py

requirements.add(repository.NARROW_REQUIREMENT) requirements.add(repository.NARROW_REQUIREMENT)
if createopts.get(b'lfs'): if createopts.get(b'lfs'):
requirements.add(b'lfs') requirements.add(b'lfs')
if ui.configbool(b'format', b'bookmarks-in-store'): if ui.configbool(b'format', b'bookmarks-in-store'):
requirements.add(bookmarks.BOOKMARKS_IN_STORE_REQUIREMENT) requirements.add(bookmarks.BOOKMARKS_IN_STORE_REQUIREMENT)
if ui.configbool(b'experimental', b'exp-persistent-nodemap'): if ui.configbool(b'format', b'use-persistent-nodemap'):
requirements.add(NODEMAP_REQUIREMENT) requirements.add(NODEMAP_REQUIREMENT)
return requirements return requirements
def filterknowncreateopts(ui, createopts): def filterknowncreateopts(ui, createopts):
"""Filters a dict of repo creation options against options that are known. """Filters a dict of repo creation options against options that are known.

tests/test-persistent-nodemap.t

=================================== ===================================
Test the persistent on-disk nodemap Test the persistent on-disk nodemap
=================================== ===================================
$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [experimental] > [format]
> exp-persistent-nodemap=yes > use-persistent-nodemap=yes
> [devel] > [devel]
> persistent-nodemap=yes > persistent-nodemap=yes
> EOF > EOF
$ hg init test-repo $ hg init test-repo
$ cd test-repo $ cd test-repo
$ hg debugbuilddag .+5000 --new-file --config "experimental.exp-persistent-nodemap.mode=warn" $ hg debugbuilddag .+5000 --new-file --config "experimental.exp-persistent-nodemap.mode=warn"
persistent nodemap in strict mode without efficient method (no-rust no-pure !) persistent nodemap in strict mode without efficient method (no-rust no-pure !)
persistent nodemap in strict mode without efficient method (no-rust no-pure !) persistent nodemap in strict mode without efficient method (no-rust no-pure !)