( )⚙ D8485 url: fix a bytes vs str crash in processing proxy headers (issue6249)

This is an archive of the discontinued Mercurial Phabricator instance.

url: fix a bytes vs str crash in processing proxy headers (issue6249)
ClosedPublic

Authored by mharbison72 on Apr 26 2020, 4:13 PM.

Details

Summary

I have no idea how to make a test for this, so if somebody knows, feel free to
add one or follow up on this. The bug reporter reported that it worked for
them, so there may not be other hidden issues here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 26 2020, 4:13 PM
marmoute accepted this revision.Apr 28 2020, 4:23 AM
marmoute added a subscriber: marmoute.

According to the discussion on the bug tracker, this is seems fine.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.