This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8608

hg-core: add Operation interface for high-level hg operations
ClosedPublic

Authored by acezar on Jun 5 2020, 10:31 AM.

Details

Reviewers
marmoute
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa46e36b82461: hg-core: add Operation interface for high-level hg operations
Summary

A distinction is made between operations and commands.
An operation is a high-level function of mercurial whereas a command is what is exposed by the cli.
A single command can use several operations to achieve its goal.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

acezar created this revision.Jun 5 2020, 10:31 AM
marmoute accepted this revision.Jun 9 2020, 5:15 AM
Alphare accepted this revision.Jun 15 2020, 5:28 AM
acezar added a commit: rHGa46e36b82461: hg-core: add Operation interface for high-level hg operations.Jun 16 2020, 5:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa46e36b82461: hg-core: add Operation interface for high-level hg operations (authored by acezar). · Explain Why
This revision was automatically updated to reflect the committed changes.
acezar updated this revision to Diff 21653.Jun 17 2020, 4:25 AM

Revision Contents
Changeset List

Diff 21653

rust/hg-core/src/lib.rs

}, },
CopyMap, CopyMapIter, DirstateEntry, DirstateParents, EntryState, CopyMap, CopyMapIter, DirstateEntry, DirstateParents, EntryState,
StateMap, StateMapIter, StateMap, StateMapIter,
}; };
mod filepatterns; mod filepatterns;
pub mod matchers; pub mod matchers;
pub mod revlog; pub mod revlog;
pub use revlog::*; pub use revlog::*;
pub mod operations;
pub mod utils; pub mod utils;
// Remove this to see (potential) non-artificial compile failures. MacOS // Remove this to see (potential) non-artificial compile failures. MacOS
// *should* compile, but fail to compile tests for example as of 2020-03-06 // *should* compile, but fail to compile tests for example as of 2020-03-06
#[cfg(not(target_os = "linux"))] #[cfg(not(target_os = "linux"))]
compile_error!( compile_error!(
"`hg-core` has only been tested on Linux and will most \ "`hg-core` has only been tested on Linux and will most \
likely not behave correctly on other platforms." likely not behave correctly on other platforms."

rust/hg-core/src/operations/mod.rs

  • This file was added.
/// An interface for high-level hg operations.
///
/// A distinction is made between operation and commands.
/// An operation is what can be done whereas a command is what is exposed by
/// the cli. A single command can use several operations to achieve its goal.
pub trait Operation<T> {
type Error;
fn run(&self) -> Result<T, Self::Error>;
}