( )⚙ D8629 tests: consistently use pyflakes as a Python module

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8629

tests: consistently use pyflakes as a Python module
ClosedPublic

Authored by marmoute on Jun 13 2020, 5:07 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf9099e210c57: tests: consistently use pyflakes as a Python module
Summary

We check availability of pyflakes as a module, and also running it for real as
a module. Only fair to test filterpyflakes.py working correctly when using
pyflakes as a module too.

This is a graft of a similar fix that ended up on default.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 13 2020, 5:07 AM
pulkit accepted this revision.Jun 15 2020, 4:33 AM
This revision is now accepted and ready to land.Jun 15 2020, 4:33 AM
av6 added a commit: rHGf9099e210c57: tests: consistently use pyflakes as a Python module.Jun 15 2020, 5:27 AM
Closed by commit rHGf9099e210c57: tests: consistently use pyflakes as a Python module (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (2 lines)

Diff 21632

tests/test-check-pyflakes.t

#require test-repo pyflakes hg10 #require test-repo pyflakes hg10
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
run pyflakes on all tracked files ending in .py or without a file ending run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed) (skipping binary file random-seed)
$ cat > test.py <<EOF $ cat > test.py <<EOF
> print(undefinedname) > print(undefinedname)
> EOF > EOF
$ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1: undefined name 'undefinedname' test.py:1: undefined name 'undefinedname'
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty \ > -X mercurial/thirdparty \
> 2>/dev/null \ > 2>/dev/null \
> | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*: undefined name 'xrange' (glob) (?) contrib/perf.py:*: undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?) mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?)
mercurial/util.py:*: undefined name 'file' (glob) (?) mercurial/util.py:*: undefined name 'file' (glob) (?)
mercurial/encoding.py:*: undefined name 'localstr' (glob) (?) mercurial/encoding.py:*: undefined name 'localstr' (glob) (?)